more feature cleanup ; fix more utils #553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31fd29e to
43d94df
Compare
Contributor
Author
|
|
This is a reworked version of unexpand. I did this for two main reasons: 1. The previous version of unexpand had issues correctly computing tabstops when the `-a` flag was supplied. 2. The previous version assumed the input was UTF-8. This version works with non-UTF-8 inputs. 3. This version has a new flag, -U, which forces unexpand to treat input as 8-bit ASCII rather than interpreting it as UTF-8. This might be handy in some cases.
This is a reworked version of expand. I did this for two main reasons: 1. The previous version assumed the input was UTF-8. This version is compatible with both UTF-8 and non-UTF-8 inputs. 2. This version has a new flag, -U, which forces expand to treat input as 8-bit ASCII rather than interpreting it as UTF-8. This might be handy in some cases.
Contributor
Author
|
Good to go now. |
In addition, this commit substantially reduces the number of allocations that tr does when building the substitution tables.
Cynede
pushed a commit
that referenced
this pull request
Apr 29, 2015
more feature cleanup ; fix more utils
jbcrail
pushed a commit
to jbcrail/coreutils
that referenced
this pull request
Apr 29, 2015
more feature cleanup ; fix more utils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
box_syntaxfeature gate infmt,base64, andcatunlinkunexpandandexpand-Uswitch that explicitly prevents the command from interpreting input as UTF-8.tr, and substantially reduces the number of allocations it does at startup.