Improve error messages for ambiguous formats#882
Merged
Conversation
musicinmybrain
added a commit
to musicinmybrain/pydantic
that referenced
this pull request
Jun 5, 2026
Release 1.23.2 contains uuid-rs/uuid#882, which improved error messes. The change included a switch from one-based to zero-based indices, which affects one of the expected messages in `test_uuid`.
5 tasks
kodiakhq Bot
pushed a commit
to pdylanross/fatigue
that referenced
this pull request
Jun 25, 2026
Bumps uuid from 1.20.0 to 1.23.4. Release notes Sourced from uuid's releases. v1.23.4 What's Changed Fix up name of fuzz script in readme by @KodrAus in uuid-rs/uuid#888 document fixes by @frostyplanet in uuid-rs/uuid#889 Prepare for 1.23.4 release by @KodrAus in uuid-rs/uuid#890 New Contributors @frostyplanet made their first contribution in uuid-rs/uuid#889 Full Changelog: uuid-rs/uuid@v1.23.3...v1.23.4 v1.23.3 What's Changed Fix up parser panic on empty input by @KodrAus in uuid-rs/uuid#886 Prepare for 1.23.3 release by @KodrAus in uuid-rs/uuid#887 Full Changelog: uuid-rs/uuid@v1.23.2...v1.23.3 v1.23.2 What's Changed Improve error messages for ambiguous formats by @KodrAus in uuid-rs/uuid#882 Prepare for 1.23.2 release by @KodrAus in uuid-rs/uuid#883 Full Changelog: uuid-rs/uuid@v1.23.1...v1.23.2 v1.23.1 What's Changed Remove deprecated msrv feature from wasm-bindgen dependency by @guybedford in uuid-rs/uuid#877 fix: Timestamp::from_gregorian deprecation note by @aznashwan in uuid-rs/uuid#878 Prepare for 1.23.1 release by @KodrAus in uuid-rs/uuid#879 New Contributors @guybedford made their first contribution in uuid-rs/uuid#877 @aznashwan made their first contribution in uuid-rs/uuid#878 Full Changelog: uuid-rs/uuid@v1.23.0...v1.23.1 v1.23.0 What's Changed feat: add support for 'hyphenated' format in the serde module by @FrenchDilettante in uuid-rs/uuid#865 Fix a number of bugs in time-related code by @KodrAus in uuid-rs/uuid#872 Reword invalid char error message by @KodrAus in uuid-rs/uuid#873 Impl cleanups by @KodrAus in uuid-rs/uuid#874 Use LazyLock to synchronize v1/v6 context initialization by @KodrAus in uuid-rs/uuid#875 Prepare for 1.23.0 release by @KodrAus in uuid-rs/uuid#876 New Contributors @FrenchDilettante made their first contribution in uuid-rs/uuid#865 ... (truncated) Commits 3296d64 Merge pull request #890 from uuid-rs/cargo/v1.23.4 cba53d0 prepare for 1.23.4 release e347af4 Merge pull request #889 from frostyplanet/main e9bf55c doc: Fix broken link warnings 5351af4 doc: Enable feature flag label for docs.rs 1e6a966 Merge pull request #888 from uuid-rs/KodrAus-patch-1 c9619f6 fix up name of fuzz script in readme 20da78b Merge pull request #887 from uuid-rs/cargo/v1.23.3 62232ca prepare for 1.23.3 release 2320c6a Merge pull request #886 from uuid-rs/fix/parser-panics Additional commits viewable in compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase. Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: @dependabot rebase will rebase this PR @dependabot recreate will recreate this PR, overwriting any edits that have been made to it @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #880
Closes #881
This PR improves our error reporting so when attempting to parse a specific format we don't report errors suggesting a different format is malformed. I've also made our indexes zero-based instead of 1-based. These fields aren't public so are unlikely to be relied on.