Skip to content

[DONTMERGE] just for testing#2629

Closed
masatake wants to merge 5 commits into
util-linux:masterfrom
masatake:temp--run-test-cases
Closed

[DONTMERGE] just for testing#2629
masatake wants to merge 5 commits into
util-linux:masterfrom
masatake:temp--run-test-cases

Conversation

@masatake

@masatake masatake commented Dec 7, 2023

Copy link
Copy Markdown
Member

For debugging #2624.

@masatake

masatake commented Dec 7, 2023

Copy link
Copy Markdown
Member Author

The error in "Build test / distcheck (pull_request) " is gone.
However, another error about lslocks appeared on rpm-build:fedora-rawhide-ppc64le.
The new one is not reported in #2625. Mysterious.

diff-{{{
--- /builddir/build/BUILD/util-linux-2.39.3/tests/expected/lslocks/lslocks-ofd--w	2023-12-07 00:06:36.000000000 +0000
+++ /builddir/build/BUILD/util-linux-2.39.3/tests/output/lslocks/lslocks-ofd--w	2023-12-07 00:21:31.724303678 +0000
@@ -1,4 +1,3 @@
-test_mkfds OFDLCK 1B WRITE 0 0
 # ofd--w + COMMAND,TYPE,SIZE,MODE,START,END + --raw --noheadings: 0
 util-linux-lslocks-target-file
 # ofd--w + PATH + --raw --noheadings: 0
}}}-diff

      lslocks: flock: [07] ofd--w                            ... FAILED (lslocks/lslocks-ofd--w)
        blkid: superblocks probing: [81] reiser4             ... OK

diff-{{{
--- /builddir/build/BUILD/util-linux-2.39.3/tests/expected/lslocks/lslocks-ofd-rw	2023-12-07 00:06:36.000000000 +0000
+++ /builddir/build/BUILD/util-linux-2.39.3/tests/output/lslocks/lslocks-ofd-rw	2023-12-07 00:21:31.764302528 +0000
@@ -1,5 +1,3 @@
-test_mkfds OFDLCK 3B READ 0 0
-test_mkfds OFDLCK 3B WRITE 2 2
 # ofd-rw + COMMAND,TYPE,SIZE,MODE,START,END + --raw --noheadings: 0
 util-linux-lslocks-target-file
 util-linux-lslocks-target-file
}}}-diff

@karelzak @masatake
lsblk: add --list-columns
be5aaf0 
Signed-off-by: Karel Zak <kzak@redhat.com>
@karelzak @masatake
lslocks: improve --list-columns
a0c65e9 
Signed-off-by: Karel Zak <kzak@redhat.com>
@karelzak @masatake
findmnt: add --list-columns
7f28d8f 
Signed-off-by: Karel Zak <kzak@redhat.com>
@masatake

masatake commented Dec 7, 2023

Copy link
Copy Markdown
Member Author

After rebasing in #2624, we got:

diff-{{{
--- /home/runner/work/util-linux/util-linux/util-linux-2.39.998-7689c/tests/expected/lslocks/lslocks-ofd--w	2023-12-07 13:57:58.566560916 +0000
+++ /home/runner/work/util-linux/util-linux/util-linux-2.39.998-7689c/_build/sub/tests/output/lslocks/lslocks-ofd--w	2023-12-07 14:03:50.896009589 +0000
@@ -1,4 +1,3 @@
 test_mkfds OFDLCK 1B WRITE 0 0
 # ofd--w + COMMAND,TYPE,SIZE,MODE,START,END + --raw --noheadings: 0
-util-linux-lslocks-target-file
 # ofd--w + PATH + --raw --noheadings: 0
}}}-diff

Before rebasing:

diff-{{{
--- /builddir/build/BUILD/util-linux-2.39.3/tests/expected/lslocks/lslocks-lease-w+HOLDERS	2023-12-05 21:57:14.000000000 +0000
+++ /builddir/build/BUILD/util-linux-2.39.3/tests/output/lslocks/lslocks-lease-w+HOLDERS	2023-12-05 22:15:38.598083700 +0000
@@ -1,2 +1,2 @@
-test_mkfds LEASE  WRITE 0 0 1,test_mkfds,17\x0a1,test_mkfds,18
+test_mkfds LEASE  WRITE 0 0 
 # lease-w + COMMAND,TYPE,SIZE,MODE,START,END,HOLDERS + --raw --noheadings: 0
}}}-diff

      lslocks: flock: [15] lease-w+HOLDERS                   ... FAILED (lslocks/lslocks-lease-w+HOLDERS)

Errors were reported multiple times, but the outputs were different in each trial.

@masatake masatake force-pushed the temp--run-test-cases branch from 8ebb266 to 7c958c6 Compare December 7, 2023 18:16
@masatake

masatake commented Dec 7, 2023

Copy link
Copy Markdown
Member Author

Solved with 26e538a . Sigh.

@masatake masatake closed this Dec 7, 2023
masatake added a commit to masatake/util-linux that referenced this pull request Dec 7, 2023
@masatake
tests: (lslcoks) insert a sleep between taking a lock and running lsl…
7bc52cc 
…ocks

Close util-linux#2624.

It appears that there is a time lag between locking and its visibility
in /proc/locks.  See the unstbale results of errors I observed in
util-linux#2629.

Signed-off-by: Masatake YAMATO <yamato@redhat.com>
@masatake masatake mentioned this pull request Dec 7, 2023
Merged
schubi2 pushed a commit to schubi2/util-linux that referenced this pull request Jan 18, 2024
@masatake @schubi2
tests: (lslcoks) insert a sleep between taking a lock and running lsl…
e63bc22 
…ocks

Close util-linux#2624.

It appears that there is a time lag between locking and its visibility
in /proc/locks.  See the unstbale results of errors I observed in
util-linux#2629.

Signed-off-by: Masatake YAMATO <yamato@redhat.com>
ahmed-masud pushed a commit to safai-labs/util-linux that referenced this pull request Feb 23, 2024
@masatake @ahmed-masud
tests: (lslcoks) insert a sleep between taking a lock and running lsl…
896e694 
…ocks

Close util-linux#2624.

It appears that there is a time lag between locking and its visibility
in /proc/locks.  See the unstbale results of errors I observed in
util-linux#2629.

Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@masatake @karelzak