USWDS-Compile - Bugfix: Fix sourcemaps pathing#79
Merged
Conversation
thisisdano
approved these changes
Nov 14, 2023
thisisdano
left a comment
Contributor
There was a problem hiding this comment.
Seems to work like a charm. I clarified Step 5 in the instructions to make it clear what we're supposed to be checking, since I was a little confused for a sec.
Merged
mdmower-csnw
added a commit
to mdmower-csnw/uswds-compile
that referenced
this pull request
Nov 21, 2024
Let end users define options that will be passed to sass-embedded during compilation. Omit outputStyle from configurable options to preserve sourcemaps paths: uswds#79. Note that includePaths is a legacy API option, so it doesn't need to be included in the types Omit<>.
mdmower-csnw
added a commit
to mdmower-csnw/uswds-compile
that referenced
this pull request
Nov 21, 2024
Let end users define options that will be passed to sass-embedded during compilation. Omit outputStyle from configurable options to preserve sourcemaps paths: uswds#79. Note that includePaths is a legacy API option, so it doesn't need to be included in the types Omit<>. Provide a good out-of-box experience by defaulting to sass options {quietDeps: true}, so that deprecation warnings related to the user's own styles are raised, but those from USWDS styles are suppressed.
mdmower-csnw
added a commit
to CSNW/uswds-compile
that referenced
this pull request
Nov 25, 2024
Let end users define options that will be passed to sass-embedded during compilation. Omit outputStyle from configurable options to preserve sourcemaps paths: uswds#79. Note that includePaths is a legacy API option, so it doesn't need to be included in the types Omit<>. Provide a good out-of-box experience by defaulting to sass options {quietDeps: true}, so that deprecation warnings related to the user's own styles are raised, but those from USWDS styles are suppressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sourcemaps show correct paths. Generated CSS now points to the correct source locations. Closes #61.
How to test
jm-test-compile-sourcemaps-fixfromuswds/uswds-siterepo.npm install && npm start./documentation/settings/page.site-notecorrectly points to_uswds-theme-custom-styles.scss(i.e. that the sourcemaps link is now correct)