Skip to content

Reorganizing repository file/folder structure#978

Merged
rogeruiz merged 15 commits into
18f-pages-stagingfrom
974-repo-reorg
Feb 3, 2016
Merged

Reorganizing repository file/folder structure#978
rogeruiz merged 15 commits into
18f-pages-stagingfrom
974-repo-reorg

Conversation

@juliasolorzano

Copy link
Copy Markdown

The work in this pull request reorganizes the files and folders to help assist with automation of the project. A few things to note:

  • The Draft WDS website pages now live in the /docs folder.
  • _config.yml has a new variable called version for us to be able to update the release version around the site more efficiently.
  • The Gemfile now includes the the web_design_standards_gem instead of relating the the actual files in the repo:

Fixes #974

@rogeruiz

rogeruiz commented Feb 2, 2016

Copy link
Copy Markdown
Contributor

This looks great. We should document the new Jekyll development process in the README. I'm not quite sure, based on the documentation in the readme, how these changes affect building the website locally. Could you update that in the readme?

@juliasolorzano

Copy link
Copy Markdown
Author

@rogeruiz thanks for your review! There should not be any changes to the README.md installation/local usage workflow, as we now have the source pointing to the /docs folder. See here: https://github.com/18F/web-design-standards/pull/978/files#diff-aeb42283af8ef8e9da40ededd3ae2ab2R7

Did some testing, but let me know if you have any specific errors or issues you are seeing as you build locally! 🚀

@juliasolorzano juliasolorzano changed the title Reorganizaing repository file/folder structure Reorganizing repository file/folder structure Feb 2, 2016
@juliasolorzano

Copy link
Copy Markdown
Author

@rogeruiz taking a second look and while the build is the same, there are some docs that DID need updating in response to where to find all the things! Those should be updated now.

@rogeruiz

rogeruiz commented Feb 2, 2016

Copy link
Copy Markdown
Contributor

Seeing some strange errors on the build for this PR.

https://travis-ci.org/18F/web-design-standards/builds/106562512#L174-L184

I'm going to attempt to rebuild this, but the new documentation looks good to me. I think it makes more sense to split the repository up into two silos with source, dist, and docs living at the root directory along with the necessary config and dotfiles within this PR. I'm comfortable merging this in once the source directory is created and pushed up.

@maya

maya commented Feb 2, 2016

Copy link
Copy Markdown
Contributor

@rogeruiz would it be source or src?

@msecret

msecret commented Feb 2, 2016

Copy link
Copy Markdown
Contributor

I say src

@juliasolorzano juliasolorzano force-pushed the 974-repo-reorg branch 5 times, most recently from 9e741d7 to c42fe88 Compare February 3, 2016 14:50
@juliasolorzano

Copy link
Copy Markdown
Author

@rogeruiz thanks for the feedback! The build is now fixed after updating the .travis.yml to remove the build via the ./go script. @mbland is working on a solve here >> 18F/go_script#16

I've also updated the repo to only hold a src/ directory, as I see the dist/ directory coming into play once your gulpification of the repo is in place.

@rogeruiz

rogeruiz commented Feb 3, 2016

Copy link
Copy Markdown
Contributor

Looks good to me 👍 🚀 🎸 💃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants