Enable npm packaging, including .css and .scss#948
Closed
mbland wants to merge 2 commits into
Closed
Conversation
Per the discussion on #925.
Contributor
|
👍 I didn't know about |
Contributor
There was a problem hiding this comment.
Isn't it just supposed to be npm run build-sass?
Contributor
Author
There was a problem hiding this comment.
Good catch. I'd had a separate "build" target previously that I'd since taken out. Done.
Contributor
|
Why wouldn't we use a |
Contributor
Author
|
@msecret Added a |
Contributor
|
Does this PR need to be opened against |
Contributor
|
LGTM |
Contributor
Contributor
|
Added into our |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the discussion on #925. Still needs documentation regarding how to use the
cssandscsskeys. For reference, here's some source material for the forthcoming documentation:cc: @maya @msecret @jeremiak