Fix homepage image from being too large in IE#940
Conversation
There was a problem hiding this comment.
We should be specific on the version of Internet Explorer that was having an issue. Please add which versions of IE this is effected by and solves for.
There was a problem hiding this comment.
@juliaelman I didn't put the IE version bc it effects all versions.
There was a problem hiding this comment.
@maya hrmmm... all versions meaning IE[X] - ? only the one's we support? Looks like you mentioned testing only on IE9 - 10.
There was a problem hiding this comment.
@juliaelman Yes all versions of IE, I explicitly tested IE9-11 and assuming it effects below IE9 as well.
There was a problem hiding this comment.
@juliaelman actually, just checked and it doesn't effect IE Edge. I can explicitly state IE11 and below.
There was a problem hiding this comment.
@maya I still think we need to be explicit and state IE9 - 11, as we have not tested other versions of IE outside of those and don't want to make any assumptions.
|
Looks good! Added note above about IE versioning, but otherwise looks good to me. |
|
@maya 👍 merge away! |
Fix homepage image from being too large in IE
Found the issue of images inside of links being too large on the homepage, which was found and fixed for Firefox in #863, also exists for IE.
Even though the container the image is in has a defined width, it does not obey its width to fill the container. Instead, it exceeds that width and appears at it's full size.
This fix adds a max-width on the image link. Safari and Chrome will fill the width of the container it's in. Firefox and IE will only do this for direct parent containers. Since this is a grandparent container, it does not obey it.
This screenshot shows this fixes the issue in IE (tested in IE9 and IE10):
Fixes #863.