Adding email links#845
Merged
Merged
Conversation
This replaces the last 'view the standards' link but that seems amply available higher up in the page.
Contributor
There was a problem hiding this comment.
Do we want to include any GA handler events in this? cc @colinpmacarthur
Contributor
|
Can we write out the full email address? Many people don't have their primary email client set up on the computer and clicking on the email link opens an email client they don't use and haven't set up an account with. Writing out the email address means they can also copy/paste into their preferred email client. |
Contributor
Author
|
We definitely could. It's a bit lengthy though and may not look good. I don't see it as a big problem but am fine either way. |
Contributor
Contributor
|
@maya the second option is compliant w our link styles (https://playbook.cio.gov/designstandards/visual-style/#links) so lets go w that one! |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In support of #844.