Skip to content

Fix error with regards to aria-hidden in accordion#746

Merged
maya merged 1 commit into
uswds:18f-pages-stagingfrom
SvanteRichter:fix-error-in-accordions
Oct 1, 2015
Merged

Fix error with regards to aria-hidden in accordion#746
maya merged 1 commit into
uswds:18f-pages-stagingfrom
SvanteRichter:fix-error-in-accordions

Conversation

@SvanteRichter

Copy link
Copy Markdown
Contributor

No description provided.

@maya

maya commented Sep 30, 2015

Copy link
Copy Markdown
Contributor

I'm pretty sure this fix is correct, can you also review this @nickbristow?

@nickbristow

Copy link
Copy Markdown
Contributor

@maya yes, (aria-hidden = true) ~= (display: hidden, invisible, offscreen)

So this pr addresses the issue.

maya pushed a commit that referenced this pull request Oct 1, 2015
Fix error with regards to aria-hidden in accordion
@maya maya merged commit 30aec11 into uswds:18f-pages-staging Oct 1, 2015
@maya

maya commented Oct 1, 2015

Copy link
Copy Markdown
Contributor

Thanks @SahAssar! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants