Optimize SVGs#723
Merged
Merged
Conversation
Closed
Contributor
|
Hey @shawnbot ! When this is no longer WIP can you re-add the |
Contributor
Author
Contributor
Author
Contributor
Author
|
@msecret I've still got the commits (one each for the |
Contributor
|
This looks good. Do we need a process documented for when we add new SVGs? Actually now that I think about it, I think we'd eventually move SVG optimization into the build process. It's something I've done with Peace corps before |
Contributor
Author
|
Yep, automating it should definitely be a thing. The bin ?= ./node_modules/.bin
svgo ?= $(bin)/svgo
all: \
optimize-svg
optimize-svg:
$(svgo) -f assets/img
$(svgo) -f assets/img/social-icons/svg
.PHONY: optimize-svg |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR optimizes all of the non-font SVGs using svgo.