Add example imgs pairings#684
Merged
Merged
Conversation
Contributor
|
Images are blurry. We should resolve. Is this the focus we want? the image is a link but doesn't have a focus state:
|
Contributor
Author
|
@maya unlinked the images. Waiting on higher res images. |
Contributor
Author
|
@maya yup, images have been updated and the class has been removed. Let me know if I missed anything else. Thanks! |
Contributor
|
@maya is this good to be merged or do you need another dev reviewer? |
Contributor
There was a problem hiding this comment.
Do we need to wrap these in <p> tags?
Contributor
Author
There was a problem hiding this comment.
@maya they were in p tags for the links that were merged before so I just added the images. It gives consistent spacing so I left it in. Let me know if you think we should take it out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added example images of font pairings like this:
The images were a little small, so they are blurry. @mollieru if you want to re-save the images. I can update them.