USWDS - Dependencies: Update prettier 3.4.2#6257
Merged
Merged
Conversation
mejiaj
reviewed
Dec 17, 2024
mejiaj
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Can we pull in the latest from develop and run again?
…te-prettier-3.4.2
amyleadem
approved these changes
Dec 17, 2024
amyleadem
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
- Confirm 3.4.2 is the latest version of prettier
- Confirm no visual regressions on affected components
- Confirm code changes are only related to spacing/formatting
- Confirm I can run
npm install,npm start,npm run testwithout error - Confirm no new changes when running
npm run prettier
21 tasks
thisisdano
reviewed
Dec 17, 2024
Comment on lines
+258
to
+259
| #{radius($theme-card-border-radius)} - | ||
| #{units($theme-card-border-width)} |
Contributor
There was a problem hiding this comment.
I like this change, more readable!
thisisdano
approved these changes
Dec 17, 2024
thisisdano
left a comment
Contributor
There was a problem hiding this comment.
Good legibility improvements throughout
Comment on lines
+207
to
+208
| ) / | ||
| -2 |
Contributor
There was a problem hiding this comment.
This change feels less intuitive, but 🤷♀️
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update Prettier to
3.4.2and format Scss.Breaking change
This is not a breaking change.
Related issue
Closes #6256
Related pull requests
#6255
Preview link
Preview link →
Problem statement
Prettier has released new minor versions: 3.4.x.
After updating, Prettier has introduced changes to how it formats scss and when it breaks content onto new lines.
Solution
Update Prettier and run formatted code.
Testing and review
developand this branch using a tool like diffcheckerDependency updates