USWDS - POAM: December ‘24#6255
Merged
Merged
Conversation
7 tasks
This was referenced Dec 13, 2024
mejiaj
previously approved these changes
Dec 17, 2024
mejiaj
left a comment
Contributor
There was a problem hiding this comment.
LGTM, installed without issues.
Wanted to note that on develop I'm currently seeing this:
55 vulnerabilities (30 moderate, 25 high)
21 tasks
Contributor
|
@cathybaptista / @mahoneycm Can you pull in the latest from |
amyleadem
approved these changes
Dec 17, 2024
amyleadem
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
Tested with Node v22.11.0.
Vulnerability count: 55 vulnerabilities (29 moderate, 26 high)
- Confirm we can run
npm install,npm start,npm build:htmlandnpm run testwithout error. - Confirmed components render as expected in Storybook
- Confirm dependency table matches the changes in package.json
thisisdano
approved these changes
Dec 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated vulnerable dependencies, updated indirect dependency for elliptic
Breaking change
This is not a breaking change.
Related issue
uswds/uswds-team#413
Preview link
Preview link:
Major changes
Before:
After:
`
Testing and review
npm installnpx gulp buildSassto test sass compilationnpm run testnpm run build:htmland confirm the script runs as expected.Dependency updates