USWDS - Header: Fix alignment in megamenu links#5630
Merged
amyleadem merged 1 commit intoNov 30, 2023
Conversation
amyleadem
approved these changes
Nov 21, 2023
amyleadem
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me! I tested the following in Chrome, Firefox, and Safari:
- Confirm megamenu and extended megamenu content aligns to left and right of
usa-navbarcontent in desktop view - Confirm no changes in the mobile view
I’d like to see how this interacts with the changes in #5418. Maybe we can create a feature branch that we can merge both into?
Contributor
Author
|
@amyleadem thanks for the review. I've created the branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Megamenu links align with logo on desktop. Links in both megamenu and extended megamenu now align correctly to the logo at the top.
Breaking change
This is not a breaking change.
Related issue
Closes #5604.
Related issue
#5417
Related to PR
Related pull requests
Related to #5418. This PR adjusts padding for non-megamenu variants.
Changelog entry: TK
Preview link
Preview links:
Problem statement
Megamenu links did not align to logo.
Develop megamenu
Develop extended megamenu
Solution
Removed padding from first and last column links.
Feature megamenu
Feature extended megamenu
Major changes
NA
Testing and review
Ensure there are no regressions in any header variant links.