USWDS - Header: Increase navigation link target size#4708
Merged
Conversation
…es padding and margin cleanup
mejiaj
approved these changes
May 23, 2022
mejiaj
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks for updating!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview
Header →
Description
Fixes #2836
Originally #4427
Modeled some of the suggestions in #2836 and #3033 which give subnav menu items a larger targeting area.
The desired effect was accomplished by setting the submenu item anchor tag to
display: block;and moving the padding from the parent tag to the anchor itself.Additional information
Current Nav menus
Suggested on #2836
After this fix