Create bigger targets for Header Nav submenu items#4427
Conversation
|
I like the block anchors, but let's remove the highlighting for now. Perhaps it's something we can enable with a setting, but I don't just want to introduce it out of nowhere. |
|
Let's also look at reducing the padding a bit, feels a bit too generous as-is. |
mejiaj
left a comment
There was a problem hiding this comment.
Added some suggestions based on @thisisdano's comments.
|
Requested changes made and pushed! @mejiaj |
mejiaj
left a comment
There was a problem hiding this comment.
We might want to update the megamenu link offset value in _header.scss. A value of units('neg-05') seems to fix it.
Noticed the following regression when focus is on megamenu links.
Basic with mega-menu
Extended header with mega-menu
Fixed in commit 4cea191. Note that I had to add this to |
USWDS - High Contrast CSS clean up
USWDS - Footer: Sync markup to match 2.13.3
USWDS: Remove unused storybook dependencies
Update download link and use correct download package
USWDS 3.0.1
Sync 3.0.1
USWDS - Repair uswds-init load flashing
|
@mahoneycm Looks like this just needs some merge conflict resolution and we're good to go |
Adding https://www.pandemicoversight.gov/ and nesdis.noaa.gov to Showcase
Adding PandemicOversight & NESDIS
USWDS - Icon: add missing contrast icons
Adding scientificdiscoveries.ars.usda.gov
…s into cm-navigation-link-target "Pull latest from develop"
Description
Modeled some of the suggestions in #2836 and #3033 which give subnav menu items a larger targeting area and a visual queue that it is selected, similar to the mobile version.
The desired effect was accomplished by setting the submenu item anchor tag to
display: block;and moving the padding from the parent tag to the anchor itself.I also set the hover state background color to
primaryfromprimary-darkerto give a highlighted effect.Additional information
Current Nav menus
Suggested on #2836
After this fix
The padding being added to the anchor tags does make the mega menu larger compared to before
Fixes #2836