[Dropdown]: Ensure select chevron is visible in forced colors mode.#4457
Merged
Conversation
added 2 commits
January 13, 2022 10:45
Contributor
|
Thank you! @mejiaj are you able to test this? It looks good in principle. |
Merged
mahoneycm
approved these changes
Jan 18, 2022
mahoneycm
left a comment
Contributor
There was a problem hiding this comment.
Looks great! Works as expected. We should consider adding this to other components where dropdown is used (time picker, combo box, headers)
Contributor
|
@mahoneycm Draft up a new issue for those other components and let's get to them asap |
Merged
mejiaj
pushed a commit
that referenced
this pull request
Mar 4, 2022
[Dropdown]: Ensure select chevron is visible in forced colors mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure select chevron is visible in forced colors mode
Resolves #4454. This PR ensures that a chevron is visible when users are in forced colors mode no matter the theme they select.
Additional information
For more information on styling for forced colors see: https://blogs.windows.com/msedgedev/2020/09/17/styling-for-windows-high-contrast-with-new-standards-for-forced-colors/
Before you hit Submit, make sure you’ve done whichever of these applies to you:
npm testand make sure the tests for the files you have changed have passed.