Skip to content

Make form error more robust#2661

Merged
el-mapache merged 4 commits into
release-2.0from
fix-date-error
Aug 10, 2018
Merged

Make form error more robust#2661
el-mapache merged 4 commits into
release-2.0from
fix-date-error

Conversation

@maya

@maya maya commented Aug 8, 2018

Copy link
Copy Markdown
Contributor
  • Changes usa-input-error to usa-form-group-error to make it more applicable.
  • De-nests input element tags inside the error message CSS into usa-input-error
  • Slight design changes to be more in line with GOV.UK design updates including removing extra padding from on error line.
  • Saved over usa-memorable-date in 0d5a6d5 so this fixes that.

😎 Preview

Refs #2304.

@maya maya requested a review from a team August 8, 2018 16:34
@maya maya changed the title Make date error more robust Make form error more robust Aug 8, 2018
@maya maya added the 2.0 label Aug 8, 2018
@el-mapache el-mapache self-assigned this Aug 10, 2018

@el-mapache el-mapache left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@el-mapache el-mapache merged commit 519a255 into release-2.0 Aug 10, 2018
@el-mapache el-mapache deleted the fix-date-error branch August 20, 2018 18:02
aduth added a commit to aduth/uswds that referenced this pull request Sep 29, 2021
**Why**: Because the styles were removed as part of uswds#2661
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants