Conversation
## Description Fixes #1245 ## Additional information * The fix from #1224 asks that all accordions on a page start as expanded either by omitting `aria-hidden` or by setting it to `false`. * The accordions on pages beyond the “Accordions” and “Visual style” pages are for “Documentation” blocks, which are expanded by default. * This PR removes `aria-hidden` from all accordion content blocks, demonstrating the application of the #1224 fix. Modifications to other pages should not be necessary beyond that required by the clean and semantic milestone.
## Description Fixes #346 ## Additional information * This PR uses `display: inline-block` to allow setting height and width to an inline element. * Uses 44 pixels for both height and width per the Apple iOS HIG * Concerns with `text-align: right` - could result in thumb hitting to the right of the hit area - actually hitting the icon to the right of the actual target. `text-align: center` used instead. * Using `text-align: center` causes the right alignment of the icons to be off when compared “Agency Contact Center” text. `position: relative; left: 13px` used in order to compensate. Slight concern that this could cause a horizontal scroll bar to appear on mobile - though, given the overall alignment of the `social-links` container - concern may be moot.
[Forms]: Remove max-width on form element, move to class
[Typography]: Remove inaccessible text links
[Pull request template]: Add checklist section to pull request template
…ea-flexible [Footer]: Fix footer social icon hit area - flexible
[UI components]: Fix scss-lint warnings
[UI components]: Split up components structure
Remove full GitHub URL from links in CONTRIBUTING file
Fixes casing, adds link to CC0 dedication
Updating files for v0.9.5 release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.