Skip to content

[Typography]: Remove inaccessible text links#1215

Merged
msecret merged 4 commits into
stagingfrom
update-text-links
Jun 13, 2016
Merged

[Typography]: Remove inaccessible text links#1215
msecret merged 4 commits into
stagingfrom
update-text-links

Conversation

@maya

@maya maya commented May 31, 2016

Copy link
Copy Markdown
Contributor

Description

Removes inaccessible text links. Removes the examples of them on the styleguide site. Manually removes some underline styles on styleguide components that should not have them.

Additional information

This is what it looks like:

screen shot 2016-05-31 at 4 35 29 pm

Resolves #812.

@ericadeahl

ericadeahl commented Jun 13, 2016

Copy link
Copy Markdown

@maya @msecret Just reviewed this in Screener. Looks good generally, but could we please make a couple exceptions:

  • On the homepage, remove the underline from "UI Components" and "Visual Style Guide"
    (Note: in the new design, we will no longer be using this heading style as a link.)

https://screener.io/app/states/56ce27e2c35ab629470001cf/57462220b5cbdc7271000066/1280x1024/Chrome:env:?state=6666cd76f96956469e7be39d750cc7d9-0

screen shot 2016-06-13 at 12 32 13 pm

- In the footer component, none of the links labeled "Primary link" should have an underline.

https://screener.io/app/states/56ce27e2c35ab629470001cf/57462220b5cbdc7271000066/1280x1024/Chrome:env:?state=95e56b66884f4cdd7a7a8879de278dd2-0

screen shot 2016-06-13 at 12 31 11 pm

@maya maya mentioned this pull request Jun 14, 2016
@maya maya deleted the update-text-links branch June 16, 2016 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants