[Website]: Add new site designs 🌈#1274
Conversation
a51ff15 to
d87e527
Compare
|
|
||
| var originalNavigationHeight = $nav.outerHeight(true); | ||
| var bannerHeight = $('.usa-site-header').outerHeight(true) - originalNavigationHeight * 0.5; | ||
| var bannerHeight = $('.usa-site-header').outerHeight(true) - originalNavigationHeight * 0.5 - 50; |
There was a problem hiding this comment.
@rogeruiz I updated the scroll location to pick it up at the right spot (it was 50px short before or activating at the end of the secondary nav instead of the beginning (expected)), but it doesn't scroll back up properly. We need site-navbar to show again after scrolling up.
* Gives more breathing room for page content * Adapted from * https://standards-staging-new-design.apps.cloud.gov/colors/ * uswds/uswds#1274
* Gives more breathing room for page content * Adapted from * https://standards-staging-new-design.apps.cloud.gov/colors/ * uswds/uswds#1274
|
@juliaelman notes below...
OK!
It's not supposed to, it's using our max width for lead text for optimal reading.
ok will look into it, thanks
C1 = full width page layout Design Principles |
|
@juliaelman Firefox bug fixed in 08b102b. |
|
NOTE: The sticky nav removal for mobile view is not to remove the sticky nav entirely. The fix in this pull request refers to removing the stickyness of the |
|
The following UI Components need be changed from Alpha to Beta:
|
|
@juliaelman I believe the components are all labeled correctly now (there were two different versions of this and we decided to go with the one where most things are in alpha) |
|
@ericadeahl thanks! The doc I was pointed to for reference had them labeled differently. thanks for clarifying what they should be for this release. |
|
@juliaelman if you scroll all the way to the right of the spreadsheet, you'll see the labels we're using - I believe @ericadeahl already planned this with @bradnunnally. |
|
@maya thank you! Looks like I was given the wrong direction and appreciate the clarification 🎉 |
|
@maya checked all of the tasks assigned to me and everything looks 👍 - nice work! |
|
@maya verified all of the tasks assigned to me & everything looks 💯 - great job! |
|
@maya Re: component maturity scale — please change "Labels" from alpha to beta then we're good to go. (@bradnunnally and I had different interpretations on that, sorry for the change!) |
|
@ericadeahl done in b8ebf8b. |
|
Woo! 💯 |
Description
Adds new site designs.
See it live: https://standards-staging-new-design.apps.cloud.gov/
Tasks [pt 1]:
usa-currentclass to nested pages and overview pages when it's the current page (sidenav desktop and mobile sidenav) ( to be verified by @juliaelman )Tasks [pt 2]:
Resolves: #1227, #1228, #1229, #1231, #1232, #1233, #564.