[Website]: Fix open keyboard header bug in landscape mode on Android#1212
Merged
Conversation
Contributor
|
Tested on a Nexus 5 in Chrome and it worked for me 👍 |
Contributor
Author
|
@donjo thanks for testing! let's see if I can fix this merge conflict and get this in. |
41c745a to
398187c
Compare
rogeruiz
added a commit
that referenced
this pull request
Jul 18, 2016
This patch references the breaking change introduced in #1212.
juliasolorzano
pushed a commit
that referenced
this pull request
Jul 19, 2016
This patch references the breaking change introduced in #1212.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug that made it unable to scroll in landscape mode with an open keyboard on Android.
Note: this will need to be tested, I was unable to test it on a device.
Aspect ratio from here: http://stackoverflow.com/questions/8883163/css-media-query-soft-keyboard-breaks-css-orientation-rules-alternative-solut
Fixes: #345