Skip to content

[Maintenance] Complete the switch from Travis CI to Circle CI#1197

Merged
yozlet merged 13 commits into
stagingfrom
je_remove-travis
May 26, 2016
Merged

[Maintenance] Complete the switch from Travis CI to Circle CI#1197
yozlet merged 13 commits into
stagingfrom
je_remove-travis

Conversation

@juliasolorzano

Copy link
Copy Markdown

This pull request is downstream from #1195

Description

This pull request includes the switch from using Travis CI to Circle CI. Here are some of the things that are accomplished in these changes:

  • Removal of unused go file and references
  • Removal of .travis.ymlfile and references
  • Updating CONTRIBUTING.md
  • Adds manifest-staging.yml to create specific config references to our staging instance
  • Adds running of unit tests against pull requests 🎉
  • Adds Circle CI badge to README.md

The Travis CI webhook has also been removed as of submission of this pull request.

@juliasolorzano

Copy link
Copy Markdown
Author

@rogeruiz @yozlet would be great to have y'alls 👀 on this pull request! We might be able to compress some things to shorten the time for the CI to run (2:50 minutes), but am thinking it might be good to merge this in for now and we work on shortening that time in future PR.

Just a reminder that this is downstream from #1195

@rogeruiz

rogeruiz commented May 26, 2016

Copy link
Copy Markdown
Contributor

🚀 🎸 looks good. I'll let @yozlet weigh in. I ran this locally from a fresh clone and everything went smooth.

@yozlet

yozlet commented May 26, 2016

Copy link
Copy Markdown
Contributor

Looks great! :shipit: once the upstream PR is merged.

@yozlet

yozlet commented May 26, 2016

Copy link
Copy Markdown
Contributor

@juliaelman Is that .18f-pages.yml file unused because Pages doesn't need it, or because we're not publishing to Pages any more? If the latter, is removal of the file going to unpublish the site from Pages? If so, we may want to hold off until we have the new 18f-pages branches in place with the redirects.

@juliasolorzano

Copy link
Copy Markdown
Author

@yozlet thanks for the inquiry! This will not remove us publishing to 18F pages, as that is determined by what branches we have in place in the repo. See the docs for 18F pages for more info.

AFAIK, this file was only in place to create the /designstandards route as the baseurl for the standards website. Assuming was because the original url was playbook.cio.gov/designstandards/. Going to revert this back for now, as I have a feeling like this might cause issues with our redirects.

@yozlet

yozlet commented May 26, 2016

Copy link
Copy Markdown
Contributor

#1195 is now merged, so merging this too! Thanks @juliaelman!

@yozlet yozlet merged commit ee7ef85 into staging May 26, 2016
@yozlet yozlet deleted the je_remove-travis branch May 26, 2016 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants