Skip to content

[Documentation] Add explanations of branches to the repo docs#1195

Merged
yozlet merged 3 commits into
stagingfrom
document-branches
May 26, 2016
Merged

[Documentation] Add explanations of branches to the repo docs#1195
yozlet merged 3 commits into
stagingfrom
document-branches

Conversation

@yozlet

@yozlet yozlet commented May 25, 2016

Copy link
Copy Markdown
Contributor

Description

Minimal explanations of what the master, staging, 18f-pages & 18f-pages-staging branches are for. Fixes #1189.

Comment thread README.md Outdated

When cutting a [release](https://github.com/18F/web-design-standards/releases), we merge from `staging` to `master`. The `master` branch holds the latest production-ready release, as well as [the production website](https://standards.usa.gov/).

The branches `18f-pages` and `18f-pages-staging` _used_ to be the primary release & development branches, back when the site was hosted on `pages.18f.gov`. Those branches still auto-deploy to 18F Pages, but will now only contain minimal redirects to the new site.

@rogeruiz rogeruiz May 26, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love use of emphasis on this line 👍 Thanks @yozlet

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! A few minor tweaks to line 118:

When developing, we create a feature branch from staging, do our work in that branch, and then create a pull request that merges back into staging.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re: Line 122: Now, this might seem super nitpicky, but I'd recommend replacing the & with the word and (unless there's a specific stylistic reason for using the ampersand).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One final note (line 122): Please remove the hyphen from auto-deploy!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, and thank you for the nitpicking! (And if you have any pointers for good hyphenation practice, I'm keen to learn.)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're most welcome! And hyphenating is, admittedly, tricky business. A general rule of thumb is to hyphenate in instances where the hyphen will clarify the intended meaning — for example, to hyphenate compound adjectives:

mean-spirited dog

However, if the description comes after the noun, no hyphen is necessary:

the dog is mean spirited.

At any rate, I'm always game to talk hyphenation!

@rogeruiz

Copy link
Copy Markdown
Contributor

@kategarklavs could you take a look at the content changes here? The branches have been renamed from 18f-pages to master and 18f-pages-staging to staging.

@juliasolorzano

Copy link
Copy Markdown

hey @rogeruiz! @kategarklavs and I are going to pair on this later this evening. Hoping to help figure out a better way to do content reviews in PR! 😄 🎉

@kategarklavs

Copy link
Copy Markdown
Contributor

Yep! Stay tuned ... we'll have more info soon.

On Thu, May 26, 2016 at 9:38 AM, Julia Elman notifications@github.com
wrote:

hey @rogeruiz https://github.com/rogeruiz! @kategarklavs
https://github.com/kategarklavs and I are going to pair on this later
this evening. Hoping to help figure out a better way to do content reviews
in PR! 😄 🎉


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#1195 (comment)

@yozlet

yozlet commented May 26, 2016

Copy link
Copy Markdown
Contributor Author

@juliaelman I realised that my branch explanation is wrong, as it talks about merging straight from staging to master rather than going via a numbered release branch. Should I leave that fix to you?

@kategarklavs

Copy link
Copy Markdown
Contributor

@yozlet and @rogeruiz -- I just took a look and made a handful of tiny, tiny recommendations. This gets my 👍

@yozlet

yozlet commented May 26, 2016

Copy link
Copy Markdown
Contributor Author

@juliaelman gave a 👍 over Slack, so merging. Thanks everyone!

@yozlet yozlet merged commit 97fa628 into staging May 26, 2016
@yozlet yozlet deleted the document-branches branch May 26, 2016 23:12
Comment thread README.md

The `staging` branch is the bleeding edge of development. When developing, we create a feature branch from `staging`, do our work in that branch, and then create a pull request that merges back into `staging`. New commits to `staging` are automatically deployed to [our staging site](https://standards-staging.usa.gov/).

The `master` branch always holds the latest production-ready release, as well as [the production website](https://standards.usa.gov/). When cutting a [release](https://github.com/18F/web-design-standards/releases), we create a release branch from `staging` named for the new version: for example, `0.9.2`. Once we've completed QA on that branch, we tag the release and merge it into the `master` branch.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yozlet our release branches follow the v0.9.x naming convention, 0.9.2 is used for tags and releases.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, well spotted @maya! Will fix.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double oops, you already did. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants