1068 spawn issues on windows#1073
Merged
rogeruiz merged 4 commits intoMar 21, 2016
Merged
Conversation
added 4 commits
March 19, 2016 09:08
Remove the local process variable used to get spawn, exec, etc. Conflicts: config/gulp/website.js
Adds cross-spawn as a dependency, and replaces spawn calls to fix issues with bundle.bat on windows
Removes some debugging code
Contributor
|
LGTM, @rogeruiz |
Contributor
|
Thanks @lobsteropteryx 🎉 Cross-compability between unix-like, linux, and windows is something we strive for. Thanks again for submitting and testing the fixes! |
rogeruiz
added a commit
that referenced
this pull request
Mar 21, 2016
…dows 1068 spawn issues on windows
This was referenced Mar 21, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the local process variable used to get spawn, exec, etc.