Fix sass-watch bug#1064
Merged
Merged
Conversation
This patch removes `copy-vendor-sass` as a dependant task to `sass`. This means that this task **must run before** any subsequent build tasks.
| @@ -1,4 +1,5 @@ | |||
| var gulp = require('gulp'); | |||
| var gutil = require('gulp-util'); | |||
Contributor
There was a problem hiding this comment.
Where does this end up getting used?
Contributor
Author
There was a problem hiding this comment.
ah ha not any more. I'll remove it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original watch tasks around
sasswere too greedy when watching for file changes and would recursively watch themselves for ever. This PR fixes this problem so thatnpm startcan successfully watch for subsequent changes to the source directories.