Catalog constraints added in oscal_catalog_metaschema.xml - see issue #1949 #1952
Catalog constraints added in oscal_catalog_metaschema.xml - see issue #1949 #1952Compton-US merged 7 commits intodevelopfrom
Conversation
…g/group/control/part/@name
…rt@name='statement'
david-waltermire
left a comment
There was a problem hiding this comment.
As a community member, I don't think this PR is ready. Comments inline.
…traint for group/part in oscal_catalog_metaschema
wendellpiez
left a comment
There was a problem hiding this comment.
This breaks backward-compatibility for anyone who might be using the value 'statement', which is no longer permitted.
Please consider adding new value(s) but not removing any values already enumerated, at least until a 2.0 version.
@wendellpiez The value |
|
If the value is not in the current schema (and only being removed from the file in the branch), I retract my objection. Adding new values to the reserved namespace is fine. I'm not super keen on 'instruction' however either - what is the requirement being addressed by it? Since users are free to mark parts in their own namespace however they like, or leave parts with no which is already valid? These are not blocking questions, but I ask because afaik they have not been addressed. FWIW, not having a registry is not in itself a reason to add new values to enumerated lists. They still incur costs to downstream developers. |
Fixed grammar. Co-authored-by: Chris Compton <daniel.compton@nist.gov>
…1949 (#1952) * Two additional allowed values for catalog/group/part/@name and catalog/group/control/part/@name * aligned the description of group/part@name='statement' and control/part@name='statement' * Fixed typo in the oscal_ssp_metaschema and updated controversial constraint for group/part in oscal_catalog_metaschema * Update src/metaschema/oscal_catalog_metaschema.xml Fixed grammar. Co-authored-by: Chris Compton <daniel.compton@nist.gov> --------- Co-authored-by: Iorga <miorga@pn129618.campus.nist.gov> Co-authored-by: Chris Compton <daniel.compton@nist.gov>
Committer Notes
Added metaschema constraints for catalog/group/part/@name to accept "statement" and for catalog/group/control/part/@name to accept "example". These changes allow more catalogs, frameworks (e.g. CSF v2) to be represented in OSCAL without extensions and
nsnot being able to be processed by GRC tools without a registry.All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
(For reviewers: The wiki has guidance on code review and overall issue review for completeness.)
Changes to Core Features: