Remove with-parent-controls developmental feature#1819
Merged
aj-stein-nist merged 2 commits intousnistgov:developfrom Jun 29, 2023
Merged
Conversation
…in the profile resolution spec that didn't exist in the model. Instead of updating the model, this PR removes the "with-parent-controls" feature from the profile resolution spec. This developmental feature should be removed for the following reasons. - This feature is not implemented in any of the current XSLT or Java implementations. - This feature is not being requested from a significant segment of the user community. The related issue usnistgov#1662 has support from 1 community member outside the NIST team. - This feature is extremely difficult to implement along with with-child-controls, which works on the opposite axis. - IMHO, profile resolution doesn't need to be made more complicated than it already is.
8 tasks
wendellpiez
previously approved these changes
Jun 27, 2023
Contributor
wendellpiez
left a comment
There was a problem hiding this comment.
Do we need a followup issue to modify the Profile Resolution Specification?
LGTM in any case.
Contributor
Specification has been updated in the PR before review, so looks to go to review, I am doing so now. |
Contributor
There was a problem hiding this comment.
The with-parent-controls flag is still included in dangling code even if removed by select-control-by-id, we need to remove that first.
NOTE to NIST Team: let's make sure we use the reviewer guidance re the checklist and checking for dead code during review.
aj-stein-nist
approved these changes
Jun 29, 2023
Contributor
|
I am going to rebase with the Markdown fix soon enough, so I will merge this first. |
aj-stein-nist
added a commit
to aj-stein-nist/OSCAL-forked
that referenced
this pull request
Jun 29, 2023
* Revert changes from usnistgov#1717 that address a documented feature in the profile resolution spec that didn't exist in the model. Instead of updating the model, this PR removes the "with-parent-controls" feature from the profile resolution spec. This developmental feature should be removed for the following reasons. - This feature is not implemented in any of the current XSLT or Java implementations. - This feature is not being requested from a significant segment of the user community. The related issue usnistgov#1662 has support from 1 community member outside the NIST team. - This feature is extremely difficult to implement along with with-child-controls, which works on the opposite axis. - IMHO, profile resolution doesn't need to be made more complicated than it already is. * PR review, delete dangling with-parent-controls flag. --------- Co-authored-by: A.J. Stein <alexander.stein@nist.gov>
8 tasks
8 tasks
aj-stein-nist
added a commit
to aj-stein-nist/OSCAL-forked
that referenced
this pull request
Jul 10, 2023
* Revert changes from usnistgov#1717 that address a documented feature in the profile resolution spec that didn't exist in the model. Instead of updating the model, this PR removes the "with-parent-controls" feature from the profile resolution spec. This developmental feature should be removed for the following reasons. - This feature is not implemented in any of the current XSLT or Java implementations. - This feature is not being requested from a significant segment of the user community. The related issue usnistgov#1662 has support from 1 community member outside the NIST team. - This feature is extremely difficult to implement along with with-child-controls, which works on the opposite axis. - IMHO, profile resolution doesn't need to be made more complicated than it already is. * PR review, delete dangling with-parent-controls flag. --------- Co-authored-by: A.J. Stein <alexander.stein@nist.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Committer Notes
This PR revert changes from #1717 that address a documented feature in the profile resolution spec that didn't exist in the OSCAL profile model. Instead of updating the model, this PR removes the "with-parent-controls" feature from the profile resolution spec.
This developmental feature should be removed for the following reasons.
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
(For reviewers: The wiki has guidance on code review and overall issue review for completeness.)
Changes to Core Features:
Have you written new tests for your core changes, as applicable?Have you included examples of how to use your new feature(s)?Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.