Don't build container for XSpec testing for fork-based PRs#1817
Merged
aj-stein-nist merged 1 commit intodevelopfrom Jun 23, 2023
Merged
Don't build container for XSpec testing for fork-based PRs#1817aj-stein-nist merged 1 commit intodevelopfrom
aj-stein-nist merged 1 commit intodevelopfrom
Conversation
As it stands, since we are evaluating using the Docker Hub registry that is not public to facilitate NIST Team development to be more efficient for local and remote testing. As this container may not exist at first commit of branch, disable on fork-based PRs for now.
Contributor
nikitawootten-nist
approved these changes
Jun 20, 2023
Contributor
Author
That's fair, sorry. I thought it will attempt to build and push to the registry as needed with the shell script though depending on the branch and existing cached version, am I mistaken? |
aj-stein-nist
added a commit
to aj-stein-nist/OSCAL-forked
that referenced
this pull request
Jun 29, 2023
As it stands, since we are evaluating using the Docker Hub registry that is not public to facilitate NIST Team development to be more efficient for local and remote testing. As this container may not exist at first commit of branch, disable on fork-based PRs for now.
aj-stein-nist
added a commit
to aj-stein-nist/OSCAL-forked
that referenced
this pull request
Jul 10, 2023
As it stands, since we are evaluating using the Docker Hub registry that is not public to facilitate NIST Team development to be more efficient for local and remote testing. As this container may not exist at first commit of branch, disable on fork-based PRs for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Committer Notes
As it stands, since we are evaluating using the Docker Hub registry that is not public to facilitate NIST Team development to be more efficient for local and remote testing. As this container may not exist at first commit of branch, disable on fork-based PRs for now.
Material to #1814 but does not close it.
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
(For reviewers: The wiki has guidance on code review and overall issue review for completeness.)
Changes to Core Features:
Have you written new tests for your core changes, as applicable?Have you included examples of how to use your new feature(s)?Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.