Fix broken cross reference enforcement in link rel=incorporated-into#1808
Merged
aj-stein-nist merged 1 commit intousnistgov:developfrom Jun 27, 2023
Conversation
…a missing key violation. This fixes that.
wendellpiez
approved these changes
Jun 26, 2023
Contributor
wendellpiez
left a comment
There was a problem hiding this comment.
Excellent, thank you.
8 tasks
aj-stein-nist
approved these changes
Jun 27, 2023
aj-stein-nist
pushed a commit
to aj-stein-nist/OSCAL-forked
that referenced
this pull request
Jun 29, 2023
…a missing key violation. This fixes that. (usnistgov#1808)
aj-stein-nist
pushed a commit
to aj-stein-nist/OSCAL-forked
that referenced
this pull request
Jul 10, 2023
…a missing key violation. This fixes that. (usnistgov#1808)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Committer Notes
This PR fixes a bug caused by
<link rel="incorporated-into">entries that target non-controls. This results in a index key violation error in oscal-cli.A new index was created that indexes controls, groups, and parts to provide appropriate cross-referencing.
The SP 800-53 rev5 catalog in oscal-content can be used to reproduce this error.
All Submissions:
"?
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
(For reviewers: The wiki has guidance on code review and overall issue review for completeness.)
Changes to Core Features:
Have you written new tests for your core changes, as applicable?Have you included examples of how to use your new feature(s)?[ ] Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.