Adjustments to align with Metaschema schema bug fixes#1805
Merged
aj-stein-nist merged 1 commit intousnistgov:release-1.0from Jun 27, 2023
Merged
Conversation
aj-stein-nist
approved these changes
Jun 6, 2023
Contributor
aj-stein-nist
left a comment
There was a problem hiding this comment.
LGTM, thanks for catching this.
wendellpiez
approved these changes
Jun 26, 2023
Contributor
wendellpiez
left a comment
There was a problem hiding this comment.
Yes, by all means, thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Committer Notes
The next Metaschema release will corrects a bug that allowed inline field and flag definitions to use
use-name. This was not intended, but has been used in OSCAL. To ensure alignment with this Metaschema change, this PR refactors out the need to useuse-namein the two places where it is used.This PR targets the
release-1.0branch, but should also be applied to develop.All Submissions:
"?
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
(For reviewers: The wiki has guidance on code review and overall issue review for completeness.)
Changes to Core Features:
[ ] Have you written new tests for your core changes, as applicable?[ ] Have you included examples of how to use your new feature(s)?[ ] Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.