Restore proper mode handling for oscal-profile-test-helper.xsl#1804
Merged
aj-stein-nist merged 1 commit intousnistgov:developfrom Jun 27, 2023
Merged
Conversation
wendellpiez
approved these changes
Jun 5, 2023
Contributor
wendellpiez
left a comment
There was a problem hiding this comment.
This bug maybe did not show up when run inside a test harness?
Contributor
I guess we need to examine that but I presume the relevant XSpec tests that use this were only recently integrated? |
aj-stein-nist
approved these changes
Jun 6, 2023
8 tasks
…heet is applied to a document.
a83b66e to
603c769
Compare
Contributor
|
I goofed on the boolean logic for gating the Docker container build for XSpec testing to only trigger on team PRs or pushes, so for now I will ignore the test failure since it will not trigger on push (it won't be a PR with |
aj-stein-nist
pushed a commit
to aj-stein-nist/OSCAL-forked
that referenced
this pull request
Jun 29, 2023
…heet is applied to a document. (usnistgov#1804)
aj-stein-nist
pushed a commit
to aj-stein-nist/OSCAL-forked
that referenced
this pull request
Jul 10, 2023
…heet is applied to a document. (usnistgov#1804)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Committer Notes
This PR removes
default-mode="scrubbingto avoid anapply-templateloop when the stylesheet is applied to a document.By setting
default-mode="scrubbing"on thexsl:stylesheetelement, all templates implicitly have the modescrubbing.When applying this stylesheet to a document, the following template matches:
The statement
<xsl:apply-templates select="$source" mode="scrubbing"/>then causes the same template to match instead of the intended template:Removing the
default-mode="scrubbingrestores the correct behavior of the earlier commit.All Submissions:
"?
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
(For reviewers: The wiki has guidance on code review and overall issue review for completeness.)
Changes to Core Features:
Have you written new tests for your core changes, as applicable?