Adding resource-fragment flag to link#1527
Merged
aj-stein-nist merged 1 commit intousnistgov:developfrom Nov 1, 2022
Merged
Conversation
3 tasks
e5a3198 to
a37c965
Compare
Defined a constraint to validate the allowed characters for a fragment. Resolves usnistgov#756.
4af43ea to
3c69362
Compare
wendellpiez
approved these changes
Nov 1, 2022
Contributor
wendellpiez
left a comment
There was a problem hiding this comment.
Looks nice thanks Dave!
aj-stein-nist
approved these changes
Nov 1, 2022
Contributor
aj-stein-nist
left a comment
There was a problem hiding this comment.
Sorry for the delay. LGTM, I had to read RFC3986 3.5 more generally and experiment with regex to make sure I am understood the constraint aligns with intent in the docs.
aj-stein-nist
pushed a commit
to aj-stein-nist/OSCAL-forked
that referenced
this pull request
Jan 10, 2023
Defined a constraint to validate the allowed characters for a fragment. Resolves usnistgov#756.
aj-stein-nist
pushed a commit
to aj-stein-nist/OSCAL-forked
that referenced
this pull request
Feb 6, 2023
Defined a constraint to validate the allowed characters for a fragment. Resolves usnistgov#756.
aj-stein-nist
pushed a commit
to aj-stein-nist/OSCAL-forked
that referenced
this pull request
Jun 29, 2023
Defined a constraint to validate the allowed characters for a fragment. Resolves usnistgov#756.
aj-stein-nist
pushed a commit
to aj-stein-nist/OSCAL-forked
that referenced
this pull request
Jul 10, 2023
Defined a constraint to validate the allowed characters for a fragment. Resolves usnistgov#756.
aj-stein-nist
pushed a commit
to galtm/OSCAL
that referenced
this pull request
Sep 28, 2023
Defined a constraint to validate the allowed characters for a fragment. Resolves usnistgov#756.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defined a constraint to validate the allowed characters for a fragment. Resolves #756.
Committer Notes
Added a new flag to link name
resource-fragmentto indicate the URI fragment to append to anyrlinkassociated with the referencedresource.Resolves #756.
All Submissions:
"?
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
Changes to Core Features: