Add possible Schematron documentation checks#1501
Merged
david-waltermire merged 6 commits intousnistgov:developfrom Nov 1, 2022
Merged
Conversation
3 tasks
3 tasks
fa5250c to
e4f710c
Compare
Contributor
|
@aj-stein-nist This needs to be rebased. |
767605b to
450b8c8
Compare
david-waltermire
suggested changes
Oct 30, 2022
Contributor
david-waltermire
left a comment
There was a problem hiding this comment.
I am good with adding these checks, but they need to be integrated into the CI. Please add this to the CI.
Contributor
Author
Will do, sir! |
450b8c8 to
1704e71
Compare
Contributor
Author
Dave, I am going to push up just a few changes to the SSP metaschema def and imported common modules metaschema def(s) for the SSP. This shows the CI/CD checker in action with the amended script to run the checks in CI/CD. https://github.com/usnistgov/OSCAL/actions/runs/3364015177/jobs/5577876131 The commit after this ought to resolve them. The other build failures are blocked until we merge the URI and link check PRs currently out for review. EDIT: As promised, this now passing with the passing Metaschema validation check. https://github.com/usnistgov/OSCAL/actions/runs/3364123554/jobs/5578110944 |
f8be060 to
3bc3954
Compare
e5a3198 to
a37c965
Compare
This is the product of the meeting and spike where we pair-programmed and came up with example Schematron rules for tentative editorial standards that can be used for reviews of models and embedded docs as part of usnistgov#801. Co-authored-by: Chris Compton <chris.compton@nist.gov> Co-authored-by: Rene Rene Tshiteya <rene-claude.tshiteya@gsa.gov> Co-authored-by: Wendell Piez <wendell.piez@nist.gov> Add CI/CD checking of Schematron doc standards checking. Always zip and upload Schematron validation results for potential debug.
3bc3954 to
00507bd
Compare
Contributor
Author
|
Rebased and ready to review. |
david-waltermire
suggested changes
Oct 31, 2022
Contributor
david-waltermire
left a comment
There was a problem hiding this comment.
We should merge the documentation check into the composition check schematron, since all inherited schematrons will be checked as well.
Contributor
Author
Sounds good, I can make those changes accordingly! |
Contributor
Author
Oh on second thought, I guess this means I need a Metaschema repo PR first, as that is where the Metaschema composition check is housed. I will refactor this and move the Schematron accordingly into the existing one, and just call it in CI/CD scripting. I will revert the |
aj-stein-nist
added a commit
to aj-stein-nist/metaschema
that referenced
this pull request
Nov 1, 2022
Relocated from usnistgov/OSCAL@ef8fa01 as previously coded in usnistgov/OSCAL#1501 for usnistgov/OSCAL#801. Relocated per feedback from Dave in that PR.
4 tasks
Contributor
Author
|
Changes made and usnistgov/metaschema#246 opened. |
david-waltermire
pushed a commit
to usnistgov/metaschema
that referenced
this pull request
Nov 1, 2022
Relocated from usnistgov/OSCAL@ef8fa01 as previously coded in usnistgov/OSCAL#1501 for usnistgov/OSCAL#801. Relocated per feedback from Dave in that PR.
david-waltermire
previously approved these changes
Nov 1, 2022
aj-stein-nist
added a commit
to aj-stein-nist/oscal-content-forked
that referenced
this pull request
Nov 1, 2022
david-waltermire
pushed a commit
to usnistgov/metaschema
that referenced
this pull request
Dec 7, 2022
Relocated from usnistgov/OSCAL@ef8fa01 as previously coded in usnistgov/OSCAL#1501 for usnistgov/OSCAL#801. Relocated per feedback from Dave in that PR.
aj-stein-nist
added a commit
to aj-stein-nist/metaschema
that referenced
this pull request
Jan 9, 2023
Relocated from usnistgov/OSCAL@ef8fa01 as previously coded in usnistgov/OSCAL#1501 for usnistgov/OSCAL#801. Relocated per feedback from Dave in that PR.
aj-stein-nist
added a commit
to aj-stein-nist/metaschema
that referenced
this pull request
Jan 10, 2023
Relocated from usnistgov/OSCAL@ef8fa01 as previously coded in usnistgov/OSCAL#1501 for usnistgov/OSCAL#801. Relocated per feedback from Dave in that PR.
aj-stein-nist
added a commit
to aj-stein-nist/metaschema
that referenced
this pull request
Jan 10, 2023
Relocated from usnistgov/OSCAL@ef8fa01 as previously coded in usnistgov/OSCAL#1501 for usnistgov/OSCAL#801. Relocated per feedback from Dave in that PR.
aj-stein-nist
added a commit
to aj-stein-nist/metaschema
that referenced
this pull request
Jan 10, 2023
Relocated from usnistgov/OSCAL@ef8fa01 as previously coded in usnistgov/OSCAL#1501 for usnistgov/OSCAL#801. Relocated per feedback from Dave in that PR.
aj-stein-nist
added a commit
to aj-stein-nist/metaschema
that referenced
this pull request
Jan 10, 2023
Relocated from usnistgov/OSCAL@ef8fa01 as previously coded in usnistgov/OSCAL#1501 for usnistgov/OSCAL#801. Relocated per feedback from Dave in that PR.
aj-stein-nist
added a commit
to aj-stein-nist/metaschema
that referenced
this pull request
Jan 10, 2023
Relocated from usnistgov/OSCAL@ef8fa01 as previously coded in usnistgov/OSCAL#1501 for usnistgov/OSCAL#801. Relocated per feedback from Dave in that PR.
aj-stein-nist
added a commit
to aj-stein-nist/OSCAL-forked
that referenced
this pull request
Jan 10, 2023
* Add possible Schematron documentation checks This is the product of the meeting and spike where we pair-programmed and came up with example Schematron rules for tentative editorial standards that can be used for reviews of models and embedded docs as part of usnistgov#801. Co-authored-by: Chris Compton <chris.compton@nist.gov> Co-authored-by: Rene Rene Tshiteya <rene-claude.tshiteya@gsa.gov> Co-authored-by: Wendell Piez <wendell.piez@nist.gov> Add CI/CD checking of Schematron doc standards checking. Always zip and upload Schematron validation results for potential debug. * After, show the Schematron checks passing after Metaschema def fixes. * Revert validate-metaschema.sh changes. * Revert refactored Schematron and remove from PR. * Update metaschema module to include updated Schematron in usnistgov/metaschema#246. Co-authored-by: David Waltermire <david.waltermire@nist.gov>
aj-stein-nist
added a commit
to aj-stein-nist/OSCAL-forked
that referenced
this pull request
Feb 6, 2023
* Add possible Schematron documentation checks This is the product of the meeting and spike where we pair-programmed and came up with example Schematron rules for tentative editorial standards that can be used for reviews of models and embedded docs as part of usnistgov#801. Co-authored-by: Chris Compton <chris.compton@nist.gov> Co-authored-by: Rene Rene Tshiteya <rene-claude.tshiteya@gsa.gov> Co-authored-by: Wendell Piez <wendell.piez@nist.gov> Add CI/CD checking of Schematron doc standards checking. Always zip and upload Schematron validation results for potential debug. * After, show the Schematron checks passing after Metaschema def fixes. * Revert validate-metaschema.sh changes. * Revert refactored Schematron and remove from PR. * Update metaschema module to include updated Schematron in usnistgov/metaschema#246. Co-authored-by: David Waltermire <david.waltermire@nist.gov>
david-waltermire
pushed a commit
to usnistgov/metaschema
that referenced
this pull request
Mar 9, 2023
Relocated from usnistgov/OSCAL@ef8fa01 as previously coded in usnistgov/OSCAL#1501 for usnistgov/OSCAL#801. Relocated per feedback from Dave in that PR.
aj-stein-nist
added a commit
to aj-stein-nist/OSCAL-forked
that referenced
this pull request
Jun 29, 2023
* Add possible Schematron documentation checks This is the product of the meeting and spike where we pair-programmed and came up with example Schematron rules for tentative editorial standards that can be used for reviews of models and embedded docs as part of usnistgov#801. Co-authored-by: Chris Compton <chris.compton@nist.gov> Co-authored-by: Rene Rene Tshiteya <rene-claude.tshiteya@gsa.gov> Co-authored-by: Wendell Piez <wendell.piez@nist.gov> Add CI/CD checking of Schematron doc standards checking. Always zip and upload Schematron validation results for potential debug. * After, show the Schematron checks passing after Metaschema def fixes. * Revert validate-metaschema.sh changes. * Revert refactored Schematron and remove from PR. * Update metaschema module to include updated Schematron in usnistgov/metaschema#246. Co-authored-by: David Waltermire <david.waltermire@nist.gov>
aj-stein-nist
added a commit
to aj-stein-nist/OSCAL-forked
that referenced
this pull request
Jul 10, 2023
* Add possible Schematron documentation checks This is the product of the meeting and spike where we pair-programmed and came up with example Schematron rules for tentative editorial standards that can be used for reviews of models and embedded docs as part of usnistgov#801. Co-authored-by: Chris Compton <chris.compton@nist.gov> Co-authored-by: Rene Rene Tshiteya <rene-claude.tshiteya@gsa.gov> Co-authored-by: Wendell Piez <wendell.piez@nist.gov> Add CI/CD checking of Schematron doc standards checking. Always zip and upload Schematron validation results for potential debug. * After, show the Schematron checks passing after Metaschema def fixes. * Revert validate-metaschema.sh changes. * Revert refactored Schematron and remove from PR. * Update metaschema module to include updated Schematron in usnistgov/metaschema#246. Co-authored-by: David Waltermire <david.waltermire@nist.gov>
nikitawootten-nist
pushed a commit
to nikitawootten-nist/metaschema-xslt
that referenced
this pull request
Jul 21, 2023
Relocated from usnistgov/OSCAL@ef8fa01 as previously coded in usnistgov/OSCAL#1501 for usnistgov/OSCAL#801. Relocated per feedback from Dave in that PR.
aj-stein-nist
added a commit
to galtm/OSCAL
that referenced
this pull request
Sep 28, 2023
* Add possible Schematron documentation checks This is the product of the meeting and spike where we pair-programmed and came up with example Schematron rules for tentative editorial standards that can be used for reviews of models and embedded docs as part of usnistgov#801. Co-authored-by: Chris Compton <chris.compton@nist.gov> Co-authored-by: Rene Rene Tshiteya <rene-claude.tshiteya@gsa.gov> Co-authored-by: Wendell Piez <wendell.piez@nist.gov> Add CI/CD checking of Schematron doc standards checking. Always zip and upload Schematron validation results for potential debug. * After, show the Schematron checks passing after Metaschema def fixes. * Revert validate-metaschema.sh changes. * Revert refactored Schematron and remove from PR. * Update metaschema module to include updated Schematron in usnistgov/metaschema#246. Co-authored-by: David Waltermire <david.waltermire@nist.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Committer Notes
This is the product of the meeting and spike where we pair-programmed and came up with example Schematron rules for tentative editorial standards that can be used for reviews of models and embedded docs as part of #801.
All Submissions:
"?
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
Changes to Core Features:
Have you added an explanation of what your changes do and why you'd like us to include them?Have you written new tests for your core changes, as applicable?Have you included examples of how to use your new feature(s)?Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.