Support additional control-origination props #784#1460
Merged
david-waltermire merged 2 commits intousnistgov:developfrom Oct 17, 2022
Merged
Support additional control-origination props #784#1460david-waltermire merged 2 commits intousnistgov:developfrom
david-waltermire merged 2 commits intousnistgov:developfrom
Conversation
aj-stein-nist
previously approved these changes
Sep 19, 2022
Contributor
aj-stein-nist
left a comment
There was a problem hiding this comment.
Like #1456, I'm A.J. and I approve this message. :-)
Contributor
|
What is the value of a prop with |
david-waltermire
suggested changes
Sep 20, 2022
Contributor
david-waltermire
left a comment
There was a problem hiding this comment.
I think we need to think more about the value side of this new property.
Contributor
Author
@david-waltermire-nist Are we wanting to review this list? |
5 tasks
Co-authored-by: David Waltermire <david.waltermire@nist.gov>
aj-stein-nist
approved these changes
Sep 29, 2022
Contributor
aj-stein-nist
left a comment
There was a problem hiding this comment.
It appears I missed this bit, but Dave pointed it out and you merged it in, so now I can approve again with more confidence we met reqs. :-)
aj-stein-nist
suggested changes
Oct 5, 2022
Contributor
aj-stein-nist
left a comment
There was a problem hiding this comment.
OK, I am going to be that guy and retract my approval so we can discuss something? Let me know when you have time to discuss, Chris (and/or others maybe).
aj-stein-nist
approved these changes
Oct 11, 2022
Contributor
aj-stein-nist
left a comment
There was a problem hiding this comment.
Back to my previous state. Will approve this PR and table further conversation of follow-on work until #1502.
aj-stein-nist
pushed a commit
that referenced
this pull request
Oct 18, 2022
david-waltermire
pushed a commit
that referenced
this pull request
Oct 31, 2022
aj-stein-nist
pushed a commit
to aj-stein-nist/OSCAL-forked
that referenced
this pull request
Jan 10, 2023
…#1460) * Support additional control-origination props usnistgov#784 * Update recommended path to target additional nodes. Co-authored-by: David Waltermire <david.waltermire@nist.gov>
aj-stein-nist
pushed a commit
to aj-stein-nist/OSCAL-forked
that referenced
this pull request
Feb 6, 2023
…#1460) * Support additional control-origination props usnistgov#784 * Update recommended path to target additional nodes. Co-authored-by: David Waltermire <david.waltermire@nist.gov>
aj-stein-nist
pushed a commit
to aj-stein-nist/OSCAL-forked
that referenced
this pull request
Jun 29, 2023
…#1460) * Support additional control-origination props usnistgov#784 * Update recommended path to target additional nodes. Co-authored-by: David Waltermire <david.waltermire@nist.gov>
aj-stein-nist
pushed a commit
to aj-stein-nist/OSCAL-forked
that referenced
this pull request
Jul 10, 2023
…#1460) * Support additional control-origination props usnistgov#784 * Update recommended path to target additional nodes. Co-authored-by: David Waltermire <david.waltermire@nist.gov>
aj-stein-nist
pushed a commit
to galtm/OSCAL
that referenced
this pull request
Sep 28, 2023
…#1460) * Support additional control-origination props usnistgov#784 * Update recommended path to target additional nodes. Co-authored-by: David Waltermire <david.waltermire@nist.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Committer Notes
Based on the request in #784, extended the xpath to include control-origination props for:
The updated xpath selected the following paths from my test case:
A note was added that the child context will override the parent
control-origination.