Add imported-from link rel to relevant SSP assemblies by aj-stein-nist · Pull Request #1403 · usnistgov/OSCAL

aj-stein-nist · 2022-08-04T17:38:35Z

Committer Notes

{Please provide a brief description of what this PR accomplishes. Be sure to reference any issues addressed. If the PR is a work-in-progress submitted for early review, please include [WIP] at the beginning of the title or mark the PR as DRAFT.}

All Submissions:

Have you selected the correct base branch per Contributing guidance?
Have you set "Allow edits and access to secrets by maintainers
"?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Have you squashed any non-relevant commits and commit messages? [instructions]
Do all automated CI/CD checks pass?

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.
~~Have you written new tests for your core changes, as applicable?~~
~~Have you included examples of how to use your new feature(s)?~~

aj-stein-nist · 2022-08-04T18:28:05Z

OK per the updated dependencies listing, I am gonna park this until #756 is implemented and circle back to this. Moving the linked issue in the TODO column.

src/metaschema/oscal_ssp_metaschema.xml

david-waltermire

Please relocate the constraint for component/link/@rel to the system-component definition.

aj-stein-nist · 2022-08-11T13:44:51Z

Please relocate the constraint for component/link/@rel to the system-component definition.

So I pushed up a separate commit 497be0d and didn't squash it yet. I understand the request, but I am not sure how this will not lead to undesirable behavior. Can you explain to me when you have a chance?

If we move it here, does this not in fact allow this prop on any any component, not only a component instance in a SSP? Do we want abstracted component-definition(s) component(s) able to have this prop and potentially lead to confusion? Let me know what I am missing.

david-waltermire

LGTM. Thanks!

aj-stein-nist · 2022-08-11T18:25:08Z

The failed CI job was the link checker from cache errors with the W3C website docs, it worked after re-run. @david-waltermire-nist, per discussion during the weekly status meeting, this is ready for review.

aj-stein-nist · 2022-08-11T18:38:37Z

Please relocate the constraint for component/link/@rel to the system-component definition.

So I pushed up a separate commit 497be0d and didn't squash it yet. I understand the request, but I am not sure how this will not lead to undesirable behavior. Can you explain to me when you have a chance?

If we move it here, does this not in fact allow this prop on any any component, not only a component instance in a SSP? Do we want abstracted component-definition(s) component(s) able to have this prop and potentially lead to confusion? Let me know what I am missing.

Also just rebased down to one commit, as the feedback concern in #1403 (review) has been explained and addressed by Dave.

david-waltermire · 2022-08-25T11:53:51Z

@aj-stein-nist This PR needs to be rebased on the latest develop.

aj-stein-nist · 2022-08-25T12:28:24Z

@aj-stein-nist This PR needs to be rebased on the latest develop.

Rebased.

src/metaschema/oscal_ssp_metaschema.xml

src/metaschema/oscal_implementation-common_metaschema.xml

README_validations.md

aj-stein-nist · 2022-08-25T15:13:29Z

Also TIL git commit --amend --signoff is needed to sign-off commits that are co-authored by team members. Now the PR commits are not so unverified.

aj-stein-nist · 2022-08-25T18:45:30Z

~~@david-waltermire-nist, I pointed this PR to a feature branch as instructed during the weekly sync for when we are ready to merge.~~ Woops, this was meant for a totally different PR, disregard! 😆

src/metaschema/oscal_ssp_metaschema.xml

Co-authored-by: David Waltermire <david.waltermire@nist.gov> Signed-off-by: Alexander Stein <alexander.stein@nist.gov>

aj-stein-nist · 2022-08-29T21:34:09Z

Rebased and waiting for pending feedback, but minor recommendation in #1403 (comment) was added before rebase. Should be good to go.

david-waltermire

LGTM. Thanks!

Co-authored-by: David Waltermire <david.waltermire@nist.gov> Signed-off-by: Alexander Stein <alexander.stein@nist.gov>

aj-stein-nist changed the base branch from main to develop August 4, 2022 17:38

aj-stein-nist self-assigned this Aug 4, 2022

aj-stein-nist force-pushed the 1023-add-imported-from-relation-to-links-in-ssp branch from 71f4454 to 3f8e1c5 Compare August 4, 2022 18:26

aj-stein-nist linked an issue Aug 4, 2022 that may be closed by this pull request

Add imported-from relation to links in SSP #1023

Closed

5 tasks

aj-stein-nist added the Scope: Modeling Issues targeted at development of OSCAL formats label Aug 4, 2022

david-waltermire reviewed Aug 9, 2022

View reviewed changes

src/metaschema/oscal_ssp_metaschema.xml Outdated Show resolved Hide resolved

david-waltermire suggested changes Aug 9, 2022

View reviewed changes

david-waltermire previously approved these changes Aug 11, 2022

View reviewed changes

aj-stein-nist changed the title ~~[WIP] Add imported-from link rel to relevant SSP assemblies~~ Add imported-from link rel to relevant SSP assemblies Aug 11, 2022

aj-stein-nist marked this pull request as ready for review August 11, 2022 18:24

aj-stein-nist dismissed david-waltermire’s stale review via 37a6830 August 11, 2022 18:37

aj-stein-nist force-pushed the 1023-add-imported-from-relation-to-links-in-ssp branch from 497be0d to 37a6830 Compare August 11, 2022 18:37

david-waltermire marked this pull request as draft August 21, 2022 02:43

david-waltermire force-pushed the develop branch from c4de2fe to 0a6189a Compare August 23, 2022 03:01

aj-stein-nist force-pushed the 1023-add-imported-from-relation-to-links-in-ssp branch from 37a6830 to 923fa0a Compare August 25, 2022 12:28

david-waltermire reviewed Aug 25, 2022

View reviewed changes

src/metaschema/oscal_ssp_metaschema.xml Outdated Show resolved Hide resolved

david-waltermire reviewed Aug 25, 2022

View reviewed changes

src/metaschema/oscal_ssp_metaschema.xml Outdated Show resolved Hide resolved

david-waltermire reviewed Aug 25, 2022

View reviewed changes

src/metaschema/oscal_ssp_metaschema.xml Outdated Show resolved Hide resolved

david-waltermire reviewed Aug 25, 2022

View reviewed changes

src/metaschema/oscal_implementation-common_metaschema.xml Outdated Show resolved Hide resolved

david-waltermire self-requested a review August 25, 2022 12:58

aj-stein-nist force-pushed the 1023-add-imported-from-relation-to-links-in-ssp branch 4 times, most recently from 36ab333 to fcdfcdd Compare August 25, 2022 14:33

aj-stein-nist force-pushed the 1023-add-imported-from-relation-to-links-in-ssp branch from fcdfcdd to 3af9f8c Compare August 25, 2022 14:39

aj-stein-nist commented Aug 25, 2022

View reviewed changes

README_validations.md Outdated Show resolved Hide resolved

aj-stein-nist marked this pull request as ready for review August 25, 2022 14:53

aj-stein-nist force-pushed the 1023-add-imported-from-relation-to-links-in-ssp branch 2 times, most recently from 1eb2bed to c4377f0 Compare August 25, 2022 15:11

aj-stein-nist changed the base branch from develop to feature-metadata-actions-assembly August 25, 2022 18:42

aj-stein-nist changed the base branch from feature-metadata-actions-assembly to develop August 25, 2022 18:48

aj-stein-nist force-pushed the 1023-add-imported-from-relation-to-links-in-ssp branch 3 times, most recently from 02ae622 to eeb54c1 Compare August 25, 2022 20:52

iMichaela reviewed Aug 26, 2022

View reviewed changes

src/metaschema/oscal_ssp_metaschema.xml Outdated Show resolved Hide resolved

imported-from relations for usnistgov#1023.

c3a8a9c

Co-authored-by: David Waltermire <david.waltermire@nist.gov> Signed-off-by: Alexander Stein <alexander.stein@nist.gov>

aj-stein-nist force-pushed the 1023-add-imported-from-relation-to-links-in-ssp branch from 60496ae to c3a8a9c Compare August 29, 2022 21:32

david-waltermire approved these changes Aug 31, 2022

View reviewed changes

david-waltermire merged commit 054a7b9 into usnistgov:develop Aug 31, 2022

aj-stein-nist added a commit to aj-stein-nist/OSCAL-forked that referenced this pull request Oct 6, 2022

imported-from relations for usnistgov#1023. (usnistgov#1403)

ad974a8

Co-authored-by: David Waltermire <david.waltermire@nist.gov> Signed-off-by: Alexander Stein <alexander.stein@nist.gov>

aj-stein-nist added a commit that referenced this pull request Oct 18, 2022

imported-from relations for #1023. (#1403)

3dca374

Co-authored-by: David Waltermire <david.waltermire@nist.gov> Signed-off-by: Alexander Stein <alexander.stein@nist.gov>

david-waltermire pushed a commit that referenced this pull request Oct 31, 2022

imported-from relations for #1023. (#1403)

8d92480

Co-authored-by: David Waltermire <david.waltermire@nist.gov> Signed-off-by: Alexander Stein <alexander.stein@nist.gov>

aj-stein-nist added a commit to aj-stein-nist/OSCAL-forked that referenced this pull request Jan 10, 2023

imported-from relations for usnistgov#1023. (usnistgov#1403)

ca4e5d3

Co-authored-by: David Waltermire <david.waltermire@nist.gov> Signed-off-by: Alexander Stein <alexander.stein@nist.gov>

aj-stein-nist added a commit to aj-stein-nist/OSCAL-forked that referenced this pull request Feb 6, 2023

imported-from relations for usnistgov#1023. (usnistgov#1403)

1a89b56

Co-authored-by: David Waltermire <david.waltermire@nist.gov> Signed-off-by: Alexander Stein <alexander.stein@nist.gov>

aj-stein-nist added a commit to aj-stein-nist/OSCAL-forked that referenced this pull request Jun 29, 2023

imported-from relations for usnistgov#1023. (usnistgov#1403)

32ba47b

Co-authored-by: David Waltermire <david.waltermire@nist.gov> Signed-off-by: Alexander Stein <alexander.stein@nist.gov>

aj-stein-nist added a commit to aj-stein-nist/OSCAL-forked that referenced this pull request Jul 10, 2023

imported-from relations for usnistgov#1023. (usnistgov#1403)

bc7b892

Co-authored-by: David Waltermire <david.waltermire@nist.gov> Signed-off-by: Alexander Stein <alexander.stein@nist.gov>

aj-stein-nist added a commit to galtm/OSCAL that referenced this pull request Sep 28, 2023

imported-from relations for usnistgov#1023. (usnistgov#1403)

a8ad3f3

Co-authored-by: David Waltermire <david.waltermire@nist.gov> Signed-off-by: Alexander Stein <alexander.stein@nist.gov>

Conversation

aj-stein-nist commented Aug 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Committer Notes

All Submissions:

Changes to Core Features:

Uh oh!

aj-stein-nist commented Aug 4, 2022

Uh oh!

Uh oh!

david-waltermire left a comment

Choose a reason for hiding this comment

Uh oh!

aj-stein-nist commented Aug 11, 2022

Uh oh!

david-waltermire left a comment

Choose a reason for hiding this comment

Uh oh!

aj-stein-nist commented Aug 11, 2022

Uh oh!

aj-stein-nist commented Aug 11, 2022

Uh oh!

david-waltermire commented Aug 25, 2022

Uh oh!

aj-stein-nist commented Aug 25, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aj-stein-nist commented Aug 25, 2022

Uh oh!

aj-stein-nist commented Aug 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

aj-stein-nist commented Aug 29, 2022

Uh oh!

david-waltermire left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

aj-stein-nist commented Aug 4, 2022 •

edited

Loading

aj-stein-nist commented Aug 25, 2022 •

edited

Loading