Profile resolver: Test finish phase, plus minor XSLT enhancements and fixes#1377
Merged
david-waltermire merged 1 commit intousnistgov:developfrom Jul 25, 2022
Merged
Conversation
XSLT - Remove template that provides link to source, because metadata phase accomplished that - Add "[last()]" predicate when passing through elements that cannot appear twice - Align with schema by passing through revisions, document-id, location, and group/link but not control/annotation - Align with schema for param insertions, `<insert type="param" id-ref="...">` - Align with schema and spec for keeping items, `<prop name="keep" value="always">` XSpec - Add tests at the level of individual templates
9 tasks
wendellpiez
approved these changes
Jul 19, 2022
Contributor
wendellpiez
left a comment
There was a problem hiding this comment.
Looking good, thanks @galtm
david-waltermire
pushed a commit
that referenced
this pull request
Aug 23, 2022
XSLT - Remove template that provides link to source, because metadata phase accomplished that - Add "[last()]" predicate when passing through elements that cannot appear twice - Align with schema by passing through revisions, document-id, location, and group/link but not control/annotation - Align with schema for param insertions, `<insert type="param" id-ref="...">` - Align with schema and spec for keeping items, `<prop name="keep" value="always">` XSpec - Add tests at the level of individual templates
aj-stein-nist
pushed a commit
to aj-stein-nist/OSCAL-forked
that referenced
this pull request
Oct 6, 2022
…1377) XSLT - Remove template that provides link to source, because metadata phase accomplished that - Add "[last()]" predicate when passing through elements that cannot appear twice - Align with schema by passing through revisions, document-id, location, and group/link but not control/annotation - Align with schema for param insertions, `<insert type="param" id-ref="...">` - Align with schema and spec for keeping items, `<prop name="keep" value="always">` XSpec - Add tests at the level of individual templates
aj-stein-nist
pushed a commit
that referenced
this pull request
Oct 18, 2022
XSLT - Remove template that provides link to source, because metadata phase accomplished that - Add "[last()]" predicate when passing through elements that cannot appear twice - Align with schema by passing through revisions, document-id, location, and group/link but not control/annotation - Align with schema for param insertions, `<insert type="param" id-ref="...">` - Align with schema and spec for keeping items, `<prop name="keep" value="always">` XSpec - Add tests at the level of individual templates
david-waltermire
pushed a commit
that referenced
this pull request
Oct 31, 2022
XSLT - Remove template that provides link to source, because metadata phase accomplished that - Add "[last()]" predicate when passing through elements that cannot appear twice - Align with schema by passing through revisions, document-id, location, and group/link but not control/annotation - Align with schema for param insertions, `<insert type="param" id-ref="...">` - Align with schema and spec for keeping items, `<prop name="keep" value="always">` XSpec - Add tests at the level of individual templates
aj-stein-nist
pushed a commit
to aj-stein-nist/OSCAL-forked
that referenced
this pull request
Jan 10, 2023
…1377) XSLT - Remove template that provides link to source, because metadata phase accomplished that - Add "[last()]" predicate when passing through elements that cannot appear twice - Align with schema by passing through revisions, document-id, location, and group/link but not control/annotation - Align with schema for param insertions, `<insert type="param" id-ref="...">` - Align with schema and spec for keeping items, `<prop name="keep" value="always">` XSpec - Add tests at the level of individual templates
aj-stein-nist
pushed a commit
to aj-stein-nist/OSCAL-forked
that referenced
this pull request
Feb 6, 2023
…1377) XSLT - Remove template that provides link to source, because metadata phase accomplished that - Add "[last()]" predicate when passing through elements that cannot appear twice - Align with schema by passing through revisions, document-id, location, and group/link but not control/annotation - Align with schema for param insertions, `<insert type="param" id-ref="...">` - Align with schema and spec for keeping items, `<prop name="keep" value="always">` XSpec - Add tests at the level of individual templates
aj-stein-nist
pushed a commit
to aj-stein-nist/OSCAL-forked
that referenced
this pull request
Jun 29, 2023
…1377) XSLT - Remove template that provides link to source, because metadata phase accomplished that - Add "[last()]" predicate when passing through elements that cannot appear twice - Align with schema by passing through revisions, document-id, location, and group/link but not control/annotation - Align with schema for param insertions, `<insert type="param" id-ref="...">` - Align with schema and spec for keeping items, `<prop name="keep" value="always">` XSpec - Add tests at the level of individual templates
aj-stein-nist
pushed a commit
to aj-stein-nist/OSCAL-forked
that referenced
this pull request
Jul 10, 2023
…1377) XSLT - Remove template that provides link to source, because metadata phase accomplished that - Add "[last()]" predicate when passing through elements that cannot appear twice - Align with schema by passing through revisions, document-id, location, and group/link but not control/annotation - Align with schema for param insertions, `<insert type="param" id-ref="...">` - Align with schema and spec for keeping items, `<prop name="keep" value="always">` XSpec - Add tests at the level of individual templates
aj-stein-nist
pushed a commit
to galtm/OSCAL
that referenced
this pull request
Sep 28, 2023
…1377) XSLT - Remove template that provides link to source, because metadata phase accomplished that - Add "[last()]" predicate when passing through elements that cannot appear twice - Align with schema by passing through revisions, document-id, location, and group/link but not control/annotation - Align with schema for param insertions, `<insert type="param" id-ref="...">` - Align with schema and spec for keeping items, `<prop name="keep" value="always">` XSpec - Add tests at the level of individual templates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Committer Notes
This pull request adds template- and function-level XSpec tests for the finish phase of the XSLT profile resolver. It also updates the underlying XSLT, mostly to align with the latest specification.
XSLT
<insert type="param" id-ref="..."><prop name="keep" value="always">XSpec
All Submissions:
"?
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
Changes to Core Features: