Updated data type documentation and schema constraints to address regex issues#1265
Merged
david-waltermire merged 2 commits intousnistgov:mainfrom May 13, 2022
Conversation
aj-stein-nist
approved these changes
May 13, 2022
Contributor
aj-stein-nist
left a comment
There was a problem hiding this comment.
Had to read a few times, test the regexes, and got distracted by xs:restriction and xs:pattern annotations but this looks good. I have a follow-on question I will ask in the discussion board, but it is outside the scope of the PR.
Contributor
|
The implied question that could or couldn't be a later enhancement I added in #1266. |
aj-stein-nist
pushed a commit
to aj-stein-nist/OSCAL-forked
that referenced
this pull request
May 16, 2022
…ex issues (usnistgov#1265) * Updated data type documentation to be consistent with schemas * Updated Metaschema toolchain to correct schema regex bugs. Resolves usnistgov#1260.
Rene2mt
pushed a commit
to Rene2mt/OSCAL
that referenced
this pull request
May 17, 2022
…ex issues (usnistgov#1265) * Updated data type documentation to be consistent with schemas * Updated Metaschema toolchain to correct schema regex bugs. Resolves usnistgov#1260.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Committer Notes
All Submissions:
"?
Changes to Core Features: