Skip to content

Migrate Link Checker Action from untitaker/hyperlink to lychee#1231

Merged
david-waltermire merged 1 commit intousnistgov:release-1.0from
aj-stein-nist:issue-1230-migrate-link-checker
May 5, 2022
Merged

Migrate Link Checker Action from untitaker/hyperlink to lychee#1231
david-waltermire merged 1 commit intousnistgov:release-1.0from
aj-stein-nist:issue-1230-migrate-link-checker

Conversation

@aj-stein-nist
Copy link
Contributor

@aj-stein-nist aj-stein-nist commented May 4, 2022

Committer Notes

Migrate the chosen GitHub Actions runner for more consistent and stable link checking of website documentation. This PR closes #1230 and also closes #737.

All Submissions:

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

@aj-stein-nist aj-stein-nist added the Scope: CI/CD Enhancements to the project's Continuous Integration and Continuous Delivery pipeline. label May 4, 2022
@aj-stein-nist aj-stein-nist added this to the OSCAL 1.0.3 milestone May 4, 2022
@aj-stein-nist aj-stein-nist changed the base branch from main to release-1.0 May 4, 2022 16:52
@aj-stein-nist aj-stein-nist force-pushed the issue-1230-migrate-link-checker branch from 6992a77 to 5e25e78 Compare May 5, 2022 01:57
@aj-stein-nist aj-stein-nist changed the title [WIP] Migrate Link Checker Action from untitaker/hyperlink to lychee Migrate Link Checker Action from untitaker/hyperlink to lychee May 5, 2022
@aj-stein-nist aj-stein-nist force-pushed the issue-1230-migrate-link-checker branch from 5e25e78 to 2f84d42 Compare May 5, 2022 02:00
@aj-stein-nist aj-stein-nist marked this pull request as ready for review May 5, 2022 02:00
@aj-stein-nist aj-stein-nist force-pushed the issue-1230-migrate-link-checker branch from 2f84d42 to 2cb5ead Compare May 5, 2022 02:08
We determined a lot of edge cases between workflow dispatch interactions
and how booleans are parsed as YAML (meaning you if check them as string
data types).
@aj-stein-nist aj-stein-nist force-pushed the issue-1230-migrate-link-checker branch from 2cb5ead to 6102951 Compare May 5, 2022 02:25
@aj-stein-nist
Copy link
Contributor Author

Hopefully last touchup and rebase from this failed run: we made an ingore pattern to specific to https://tools.ietf.org/html/rfc/.* so https://tools.ietf.org/html/draft-handrews-json-schema-validation-01#section-6.1.1 was not exempted, relaxed it back to ...html.* for now.

@aj-stein-nist aj-stein-nist linked an issue May 5, 2022 that may be closed by this pull request
3 tasks
Copy link
Contributor

@david-waltermire david-waltermire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for doing all of this.

@david-waltermire david-waltermire merged commit 6de4fb3 into usnistgov:release-1.0 May 5, 2022
david-waltermire pushed a commit that referenced this pull request May 5, 2022
…ws. (#1231)

We determined a lot of edge cases between workflow dispatch interactions
and how booleans are parsed as YAML (meaning you if check them as string
data types).
Rene2mt pushed a commit to Rene2mt/OSCAL that referenced this pull request May 17, 2022
…ws. (usnistgov#1231)

We determined a lot of edge cases between workflow dispatch interactions
and how booleans are parsed as YAML (meaning you if check them as string
data types).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: CI/CD Enhancements to the project's Continuous Integration and Continuous Delivery pipeline.

Projects

None yet

2 participants