Skip to content

Clarified referencing a profile or catalog in import-profile#1227

Merged
david-waltermire merged 1 commit intousnistgov:release-1.0from
david-waltermire:issue1211-clarify-import-profile
May 4, 2022
Merged

Clarified referencing a profile or catalog in import-profile#1227
david-waltermire merged 1 commit intousnistgov:release-1.0from
david-waltermire:issue1211-clarify-import-profile

Conversation

@david-waltermire
Copy link
Contributor

Committer Notes

Added text defining the correct behavior for SSP processors when the import-profile references either an OSCAL profile or catalog. Provided guidance on use of profile references instead of catalog references. Resolves #1211.

All Submissions:

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

Copy link
Contributor

@aj-stein-nist aj-stein-nist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So what's the long-term approach gonna be? I know this simply clarifies the document, but means the actual element name is confusing.

Copy link
Contributor

@aj-stein-nist aj-stein-nist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We re-discussed this and it looks good to go, thanks for talking through this with me!

@david-waltermire david-waltermire force-pushed the issue1211-clarify-import-profile branch from a0a2cf9 to 8d04392 Compare May 4, 2022 15:11
@david-waltermire david-waltermire merged commit cf0a242 into usnistgov:release-1.0 May 4, 2022
@david-waltermire david-waltermire deleted the issue1211-clarify-import-profile branch May 4, 2022 15:55
@wendellpiez
Copy link
Contributor

Thanks @aj-stein-nist! (and @david-waltermire-nist!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update SSP reference documentation for import-profile element

3 participants