Profile resolver: Metadata tests and way of determining top UUID by galtm · Pull Request #1175 · usnistgov/OSCAL

galtm · 2022-03-15T00:35:27Z

Committer Notes

This pull request adds XSpec tests for the profile resolver's metadata phase and also includes minor updates in the XSLT, mostly to align with latest profile resolver spec.

Remove global parameter assign-uuid (note backward incompatibility - is it OK?)
Instead, support global parameters uuid-method and top-uuid, in uuid-method-choice.xsl
Support global parameter hide-source-profile-uri
Stub of opr:oscal-version function
Stub of message handler template, using xsl:message for now
Add XSpec tests

All Submissions:

Have you selected the correct base branch per Contributing guidance?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Have you squashed any non-relevant commits and commit messages? [instructions]
Do all automated CI/CD checks pass?

I don't think my XSLT updates are changes in core features, but let me know if they are.

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you included examples of how to use your new feature(s)?
Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

wendellpiez · 2022-03-15T17:28:41Z

Created #1178 to amend readmes at top level, which now require revision. Formerly, the Profile Resolver was used primarily in CI/CD and had simple entry points with no parameters. Now it supports runtime flags, we also need to write the documentation.

wendellpiez

Made #1178 as follow-on

david-waltermire · 2022-03-29T21:50:03Z

@wendellpiez and @galtm Should we address #1178 before merging this? This could be done as a PR against or update to @galtm 's branch.

wendellpiez · 2022-03-29T22:03:02Z

Sure, @galtm what makes sense to you? It's easy enough for me to make a PR using Github alone for this task. Alternatively if you know what you need to know, it would likely be easy to fold in.

galtm · 2022-03-30T00:18:25Z

@wendellpiez and @david-waltermire-nist , are you asking if I can do #1178? I don't mind updating a readme. I have two questions, though.

I noticed that 1178 says it is for v1.0.3, but I assumed this PR would be for a later version. If I mention the runtime flags as in this PR, should I do that on the develop branch and then 1178 is not really for v1.0.3?
Is there more than one readme about the profile resolver? The one I see is https://github.com/usnistgov/OSCAL/blob/main/src/utils/util/resolver-pipeline/readme.md.

wendellpiez · 2022-03-30T13:17:32Z

@galtm it looks likely to me #1178 is mislabelled and it should be 1.1.0 - @david-waltermire-nist ?

As for which readme, how about updating the one you see, which pertains specifically to how to operate this pipeline, and give us a heads-up if you see anything amiss or wrong in any of the others? We could track loose ends on the Issue and either make edits accordingly or spin off new Issues.

galtm · 2022-03-30T16:00:42Z

@wendellpiez , your idea sounds fine to me, pending version confirmation from @david-waltermire-nist .

galtm · 2022-04-05T12:06:39Z

I pushed 0d0c508 to address #1178 . Also,

I clarified what is in the testing subfolder.
I made some editorial-type updates that I hope are enhancements.
Based on a conversation with @wendellpiez , I changed $home from a global XSLT parameter (settable when invoking the pipeline) to a global XSLT variable because we didn't think the value needed to be settable from the outside.

@wendellpiez and @david-waltermire-nist : Let me know if you want to iterate on the readme or if there's anything else I should do for this PR.

- Remove global parameter assign-uuid (note backward incompatibility - is it OK?) - Instead, support global parameters uuid-method and top-uuid, in uuid-method-choice.xsl - Support global parameter hide-source-profile-uri - Stub of opr:oscal-version function - Stub of message handler template, using xsl:message for now - Add XSpec tests

…be set from outside

wendellpiez

Awesome! thanks @galtm

david-waltermire

Thanks Amanda!

- Metadata tests and way of determining top UUID - Remove global parameter assign-uuid (note backward incompatibility - is it OK?) - Instead, support global parameters uuid-method and top-uuid, in uuid-method-choice.xsl - Support global parameter hide-source-profile-uri - Stub of opr:oscal-version function - Stub of message handler template, using xsl:message for now - Add XSpec tests - Add table of parameters and clarify testing folder content - Change "home" from global param to global variable; does not need to be set from outside

…istgov#1175) - Metadata tests and way of determining top UUID - Remove global parameter assign-uuid (note backward incompatibility - is it OK?) - Instead, support global parameters uuid-method and top-uuid, in uuid-method-choice.xsl - Support global parameter hide-source-profile-uri - Stub of opr:oscal-version function - Stub of message handler template, using xsl:message for now - Add XSpec tests - Add table of parameters and clarify testing folder content - Change "home" from global param to global variable; does not need to be set from outside

- Metadata tests and way of determining top UUID - Remove global parameter assign-uuid (note backward incompatibility - is it OK?) - Instead, support global parameters uuid-method and top-uuid, in uuid-method-choice.xsl - Support global parameter hide-source-profile-uri - Stub of opr:oscal-version function - Stub of message handler template, using xsl:message for now - Add XSpec tests - Add table of parameters and clarify testing folder content - Change "home" from global param to global variable; does not need to be set from outside

…istgov#1175) - Metadata tests and way of determining top UUID - Remove global parameter assign-uuid (note backward incompatibility - is it OK?) - Instead, support global parameters uuid-method and top-uuid, in uuid-method-choice.xsl - Support global parameter hide-source-profile-uri - Stub of opr:oscal-version function - Stub of message handler template, using xsl:message for now - Add XSpec tests - Add table of parameters and clarify testing folder content - Change "home" from global param to global variable; does not need to be set from outside

david-waltermire requested a review from wendellpiez March 15, 2022 15:59

wendellpiez mentioned this pull request Mar 15, 2022

Profile resolution how-to readmes #1178

Closed

wendellpiez previously approved these changes Mar 15, 2022

View reviewed changes

galtm dismissed wendellpiez’s stale review via 0d0c508 April 5, 2022 11:54

galtm force-pushed the wip-profiler-tests-2 branch from b997f8e to 0d0c508 Compare April 5, 2022 11:54

galtm added 3 commits April 5, 2022 07:53

Add table of parameters and clarify testing folder content

0d0c508

Change "home" from global param to global variable; does not need to …

e6f284c

…be set from outside

galtm mentioned this pull request Apr 15, 2022

XSLT Profile Resolver compatibility documentation #1205

Open

david-waltermire linked an issue Apr 15, 2022 that may be closed by this pull request

Profile resolution how-to readmes #1178

Closed

david-waltermire requested a review from wendellpiez April 15, 2022 13:18

david-waltermire added this to the OSCAL 1.1.0 milestone Apr 15, 2022

wendellpiez approved these changes Apr 15, 2022

View reviewed changes

david-waltermire approved these changes Apr 15, 2022

View reviewed changes

david-waltermire merged commit de13b23 into usnistgov:develop Apr 15, 2022

galtm deleted the wip-profiler-tests-2 branch April 17, 2022 15:53

galtm mentioned this pull request Oct 29, 2022

UUID and message handling code copied from OSCAL repo usnistgov/xslt3-functions#3

Merged

aj-stein-nist removed this from the v1.1.0 milestone Jul 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Profile resolver: Metadata tests and way of determining top UUID#1175

Profile resolver: Metadata tests and way of determining top UUID#1175
david-waltermire merged 3 commits intousnistgov:developfrom
galtm:wip-profiler-tests-2

galtm commented Mar 15, 2022

Uh oh!

wendellpiez commented Mar 15, 2022

Uh oh!

wendellpiez left a comment

Uh oh!

david-waltermire commented Mar 29, 2022

Uh oh!

wendellpiez commented Mar 29, 2022

Uh oh!

galtm commented Mar 30, 2022

Uh oh!

wendellpiez commented Mar 30, 2022

Uh oh!

galtm commented Mar 30, 2022

Uh oh!

galtm commented Apr 5, 2022

Uh oh!

wendellpiez left a comment

Uh oh!

david-waltermire left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

galtm commented Mar 15, 2022

Committer Notes

All Submissions:

Changes to Core Features:

Uh oh!

wendellpiez commented Mar 15, 2022

Uh oh!

wendellpiez left a comment

Choose a reason for hiding this comment

Uh oh!

david-waltermire commented Mar 29, 2022

Uh oh!

wendellpiez commented Mar 29, 2022

Uh oh!

galtm commented Mar 30, 2022

Uh oh!

wendellpiez commented Mar 30, 2022

Uh oh!

galtm commented Mar 30, 2022

Uh oh!

galtm commented Apr 5, 2022

Uh oh!

wendellpiez left a comment

Choose a reason for hiding this comment

Uh oh!

david-waltermire left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants