Skip to content

Check runner.invoke has run successfully in tests#553

Merged
nathanjmcdougall merged 12 commits into
mainfrom
552-dont-use-runnerinvoke-in-tests-without-checking-the-result
Jun 25, 2025
Merged

Check runner.invoke has run successfully in tests#553
nathanjmcdougall merged 12 commits into
mainfrom
552-dont-use-runnerinvoke-in-tests-without-checking-the-result

Conversation

@nathanjmcdougall

Copy link
Copy Markdown
Collaborator

No description provided.

@nathanjmcdougall nathanjmcdougall linked an issue Apr 24, 2025 that may be closed by this pull request
@nathanjmcdougall

Copy link
Copy Markdown
Collaborator Author

We are hitting #558.

@nathanjmcdougall

Copy link
Copy Markdown
Collaborator Author
Failed to run uv subprocess:
stderr='/tmp/pytest-of-runner/pytest-1/test_several_tools_add_and_rem0/benchmark
/.venv/bin/python3: error while loading shared libraries: 
/tmp/pytest-of-runner/pytest-1/test_several_tools_add_and_rem0/benchmark/.venv/b
in/../lib/libpython3.10.so.1.0: cannot open shared object file: No such file or 
directory\n'

Annoying... Might be related to the issues being faced in #288

@codspeed-hq

codspeed-hq Bot commented Jun 25, 2025

Copy link
Copy Markdown

CodSpeed WallTime Performance Report

Merging #553 will not alter performance

Comparing 552-dont-use-runnerinvoke-in-tests-without-checking-the-result (c383b5d) with main (3f8e1f8)

Summary

✅ 2 untouched benchmarks

@codecov

codecov Bot commented Jun 25, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@nathanjmcdougall nathanjmcdougall merged commit ce02cc7 into main Jun 25, 2025
19 checks passed
@nathanjmcdougall nathanjmcdougall deleted the 552-dont-use-runnerinvoke-in-tests-without-checking-the-result branch June 25, 2025 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't use runner.invoke in tests without checking the result

1 participant