Skip to content

373 add from future import annotations where possible#375

Merged
nathanjmcdougall merged 4 commits into
mainfrom
373-add-from-__future__-import-annotations-where-possible
Mar 4, 2025
Merged

373 add from future import annotations where possible#375
nathanjmcdougall merged 4 commits into
mainfrom
373-add-from-__future__-import-annotations-where-possible

Conversation

@nathanjmcdougall

Copy link
Copy Markdown
Collaborator

No description provided.

@nathanjmcdougall nathanjmcdougall linked an issue Mar 4, 2025 that may be closed by this pull request
@codspeed-hq

codspeed-hq Bot commented Mar 4, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #375 will not alter performance

Comparing 373-add-from-future-import-annotations-where-possible (5b8fd55) with main (2c58170)

Summary

✅ 1 untouched benchmarks

@codecov-commenter

codecov-commenter commented Mar 4, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.51%. Comparing base (2c58170) to head (5b8fd55).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #375      +/-   ##
==========================================
+ Coverage   97.47%   97.51%   +0.04%     
==========================================
  Files          70       70              
  Lines        2970     3018      +48     
==========================================
+ Hits         2895     2943      +48     
  Misses         75       75              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nathanjmcdougall

Copy link
Copy Markdown
Collaborator Author

Well, unfortunately doesn't look like there's been an appreciable performance gain (at least not via the benchmark we have here) but it's undoubtedly more organized and prepares for Python 3.14 ([PEP 649](PEP 649)) so I'm happy to merge this.

@nathanjmcdougall nathanjmcdougall merged commit bb97936 into main Mar 4, 2025
@nathanjmcdougall nathanjmcdougall deleted the 373-add-from-__future__-import-annotations-where-possible branch March 4, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add from __future__ import annotations where possible

2 participants