Skip to content

Add missing PyprojectTOMLManager manager and test#365

Merged
nathanjmcdougall merged 1 commit into
mainfrom
343-bug-with-pyprojecttoml-opener-for-usethis-tool-coverage
Mar 4, 2025
Merged

Add missing PyprojectTOMLManager manager and test#365
nathanjmcdougall merged 1 commit into
mainfrom
343-bug-with-pyprojecttoml-opener-for-usethis-tool-coverage

Conversation

@nathanjmcdougall

Copy link
Copy Markdown
Collaborator

No description provided.

@nathanjmcdougall nathanjmcdougall linked an issue Mar 4, 2025 that may be closed by this pull request
@codspeed-hq

codspeed-hq Bot commented Mar 4, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #365 will degrade performances by 21.68%

Comparing 343-bug-with-pyprojecttoml-opener-for-usethis-tool-coverage (aa05914) with main (4fb32f5)

Summary

❌ 1 (👁 1) regressions

Benchmarks breakdown

Benchmark BASE HEAD Change
👁 test_several_tools_add_and_remove 641.4 ms 818.9 ms -21.68%

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.47%. Comparing base (4fb32f5) to head (aa05914).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #365   +/-   ##
=======================================
  Coverage   97.47%   97.47%           
=======================================
  Files          70       70           
  Lines        2970     2970           
=======================================
  Hits         2895     2895           
  Misses         75       75           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nathanjmcdougall

Copy link
Copy Markdown
Collaborator Author

I think with this regression we are just paying back the supposed +25% performance gain we had recently, it was probably invertedly introducing this bug.

@nathanjmcdougall nathanjmcdougall merged commit 2c58170 into main Mar 4, 2025
@nathanjmcdougall nathanjmcdougall deleted the 343-bug-with-pyprojecttoml-opener-for-usethis-tool-coverage branch March 4, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug with pyproject.toml opener for usethis tool coverage

2 participants