CodSpeed Performance Report

Merging #301 will improve performances by 25.37%

_{Comparing 299-handle-missing-projectversion-field-in-pyprojecttoml (da29758) with main (0c6fb50)}

Summary

⚡ 1 improvements

Benchmarks breakdown

Codecov Report

Attention: Patch coverage is 95.16908% with 10 lines in your changes missing coverage. Please review.

Project coverage is 96.59%. Comparing base (0c6fb50) to head (da29758).

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main     #301      +/-   ##
==========================================
+ Coverage   95.03%   96.59%   +1.56%     
==========================================
  Files          61       66       +5     
  Lines        2759     2878     +119     
==========================================
+ Hits         2622     2780     +158     
+ Misses        137       98      -39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

There is definitely a performance regression to address. One idea would be: only read the pyproject.toml once for the whole call. When we "write" we just save to global state until the very last moment and then on packdown we actually do the write. The idea being, we can avoid doing as much IO.

Also, need to add test coverage for the following cases:

• not project section at all
• invalid dtype for project
• invalid dtype for project.dynamic
• Not needed for test coverage, but probably good to have a test which checks that we don't try and add project.version when project.dynamic contains "version".