250 add frozen flag#254
Merged
nathanjmcdougall merged 6 commits intoFeb 4, 2025
Merged
Conversation
Collaborator
|
Hi @harshithsaiv, thanks so much for this contribution - it is basically exactly how I would have done it. By addressing the UTF-8 issue, this also closes #49 - although I've added a commit which tweaks the way you've done it. This project uses some linters, formatters and a type checker - these were failing in CI. If you run However, I've done this manually for you in this case, so now we'll see whether the CI passes. |
This was
linked to
issues
Feb 4, 2025
CodSpeed Performance ReportMerging #254 will not alter performanceComparing Summary
|
nathanjmcdougall
added a commit
that referenced
this pull request
Feb 4, 2025
See #254 - there are now multiple contributors.
This was referenced Feb 4, 2025
Merged
nathanjmcdougall
added a commit
that referenced
this pull request
Feb 4, 2025
See #254 - there are now multiple contributors.
Collaborator
|
Great, all merged. I've also recognized your shared copyright with myself now via #255. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
• Added support for a new --frozen flag for CLI commands.
The frozen attribute is now part of the global configuration (UsethisConfig) with a corresponding context manager update. The uv subprocess call now appends the "--frozen" flag when enabled.
• Updated _console.py to improve support on Windows, ensuring proper handling of error output and console functionality.
These changes resolve failing test cases related to the --frozen flag and address platform-specific console issues on Windows.