Reset usethis_config to defaults between tests in clear_functools_caches fixture#1829
Merged
nathanjmcdougall merged 4 commits intoApr 7, 2026
Merged
Conversation
Update the autouse fixture to reset the global usethis_config to its defaults before each test, preventing stale inferred values (like inferred_backend) from leaking between tests. Also update _vary_network_conn to be function-scoped with an explicit dependency on clear_functools_caches to ensure config is reset before the offline flag is set. Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/57778f3c-1cd5-4071-81e4-33024425a320 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>
…ement Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/57778f3c-1cd5-4071-81e4-33024425a320 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update clear_functools_caches fixture to reset inferred config values
Reset Apr 6, 2026
usethis_config to defaults between tests in clear_functools_caches fixture
nathanjmcdougall
approved these changes
Apr 7, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
usethis_config.inferred_backend(and potentially other inferred values) persisted across tests, causing stale cached config to silently affect subsequent tests.Changes
usethis_config._restore(UsethisConfig())to theclear_functools_cachesautouse fixture, resetting all config fields to defaults before each test_vary_network_connscope change: Downgrade fromscope="session"to function-scoped with an explicit dependency onclear_functools_cachesto guarantee the config is reset before the offline flag is re-applied_vary_network_connsince the config reset handles cleanup