Consider .python-version when inferring the Python version#1790
Merged
Conversation
Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/81b4db4f-4a63-4cf6-a10c-be549e99bdf5 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix version inference by considering .python-version
Consider Apr 4, 2026
.python-version when inferring the Python version
nathanjmcdougall
requested changes
Apr 4, 2026
Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/da698465-9d86-44e2-b743-5c40ba121488 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
nathanjmcdougall
requested changes
Apr 4, 2026
Contributor
Author
|
@nathanjmcdougall I've opened a new pull request, #1802, to work on those changes. Once the pull request is ready, I'll request review from you. |
Collaborator
|
@copilot the PR was empty and you didn't make tickets for the lessons. Try again. |
…ftest Agent-Logs-Url: https://github.com/usethis-python/usethis-python/sessions/fd92765f-45c3-47a9-88fc-14abf9492211 Co-authored-by: nathanjmcdougall <18602289+nathanjmcdougall@users.noreply.github.com>
nathanjmcdougall
approved these changes
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from_python_version_file(path: Path)classmethod toPythonVersion_get_current_python_version()helper and updateget_supported_minor_python_versions()to use it_get_current_python_version()now appears after its callersonarqube/config.pyto use the new classmethod_get_current_python_version()with@functools.cacheand register inconftest.py@functools.cacheand register in conftestexport-functions.pyexcludes private functions fromdocs/functions.txt