A previous PR introduced PreCommitConfig.from_system_hook() with parameters (always_run, pass_filenames, require_serial) that were always called with the same value — a YAGNI violation. The parameters were removed in that PR; this captures the principle as a reusable agent skill.

Changes

• usethis-python-functions skill (v1.0 → v1.1): adds a "YAGNI: don't add function parameters you don't need yet" section covering:
  • Only introduce a parameter when at least two distinct values are actually used at call sites
  • Applies especially to helper/internal functions
  • Diagnostic signs, corrective steps, and a concrete before/after example drawn from the from_system_hook case:

# Bad: always_run is always True, pass_filenames is always False
def make_hook(hook_id: str, entry: str, *, always_run: bool, pass_filenames: bool) -> Hook: ...

# Good: hardcode values that never change
def make_hook(hook_id: str, entry: str) -> Hook:
    always_run = True
    pass_filenames = False
    ...

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.