test: add unit tests for argument_parser #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comprehensive test suite for the argument_parser module including: - Tests for _convert_to_bool with truthy/falsy values - Tests for _convert_to_list with JSON and comma-separated inputs - Tests for _convert_to_dict with valid/invalid JSON - Tests for convert_string_to_type with various type annotations - Tests for convert_arguments with typed functions - Tests for ArgumentConversionError exception class This establishes the foundation for the project's test infrastructure with pytest configuration already in place.
Member
|
LGTM! @Jeong-Ryeol |
Jeong-Ryeol
added a commit
to Jeong-Ryeol/strix
that referenced
this pull request
Dec 5, 2025
Following up on @0xallam's comment on usestrix#157: > "I think we need to add even more unit tests now, especially to the most critical parts of the agent." This PR adds tests for `llm/utils.py` - the core LLM response parsing logic. Addresses usestrix#158 What's included: - TestParseToolInvocations: XML tool invocation parsing (8 tests) - TestFixStopword: Incomplete function tag handling (4 tests) - TestFormatToolCall: Tool call XML formatting (4 tests) - TestCleanContent: Content cleaning and XML removal (6 tests) - TestTruncateToFirstFunction: First function truncation (4 tests) Total: 26 tests, all passing.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #158
Added unit tests for the argument_parser module.
Noticed there weren't any tests yet, so I started with argument_parser since it has clean, testable functions.
What's included:
Let me know if you'd like any changes!